Changeset 259565 in webkit

Timestamp:

Apr 5, 2020, 11:02:06 PM (6 years ago)

Author:

Ross Kirsling

Message:

DLLLauncherMain print to console instead of opening window on fatal error
​https://bugs.webkit.org/show_bug.cgi?id=206537

Reviewed by Fujii Hironori.

Source/JavaScriptCore:

• shell/DLLLauncherMain.cpp:

(fatalError):

Tools:

• win/DLLLauncher/DLLLauncherMain.cpp:

(fatalError):

Location:

trunk

Files:

• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/shell/DLLLauncherMain.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/win/DLLLauncher/DLLLauncherMain.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-05  Gus Caplan  <me@gus.host> and Ross Kirsling  <ross.kirsling@sony.com>
+
+        DLLLauncherMain print to console instead of opening window on fatal error
+        https://bugs.webkit.org/show_bug.cgi?id=206537
+
+        Reviewed by Fujii Hironori.
+
+        * shell/DLLLauncherMain.cpp:
+        (fatalError):
+
 2020-04-05  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/JavaScriptCore/shell/DLLLauncherMain.cpp

@@ -95 +95 @@
 {
     std::wstring caption = programName + L" can't open.";
+#if USE_CONSOLE_ENTRY_POINT
+    fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str());
+#else
     ::MessageBoxW(0, message.c_str(), caption.c_str(), MB_ICONERROR);
+#endif
     return 1;
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-05  Gus Caplan  <me@gus.host> and Ross Kirsling  <ross.kirsling@sony.com>
+
+        DLLLauncherMain print to console instead of opening window on fatal error
+        https://bugs.webkit.org/show_bug.cgi?id=206537
+
+        Reviewed by Fujii Hironori.
+
+        * win/DLLLauncher/DLLLauncherMain.cpp:
+        (fatalError):
+
 2020-04-05  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp

@@ -97 +97 @@
 {
     wstring caption = programName + L" can't open.";
+#if USE_CONSOLE_ENTRY_POINT
+    fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str());
+#else
     ::MessageBoxW(0, message.c_str(), caption.c_str(), MB_ICONERROR);
+#endif
     return 1;
 }