Changeset 259591 in webkit

Timestamp:

Apr 6, 2020, 1:36:58 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r259469.
​https://bugs.webkit.org/show_bug.cgi?id=210066

Introduced media playback regression (Requested by perarne on
#webkit).

Reverted changeset:

"[iOS] Deny mach lookup access to the runningboard service in
the WebContent process"
​https://bugs.webkit.org/show_bug.cgi?id=209933
​https://trac.webkit.org/changeset/259469

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (modified) (1 diff)
• LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-04-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r259469.
+        https://bugs.webkit.org/show_bug.cgi?id=210066
+
+        Introduced media playback regression (Requested by perarne on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Deny mach lookup access to the runningboard service in
+        the WebContent process"
+        https://bugs.webkit.org/show_bug.cgi?id=209933
+        https://trac.webkit.org/changeset/259469
+
 2020-04-06  Jacob Uphoff  <jacob_uphoff@apple.com>
 

trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt

@@ -28 +28 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.frontboard.systemappservices") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.runningboard") is false

trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html

@@ -31 +31 @@
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.frontboard.systemappservices\")");
-    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.runningboard\")");
 }
 </script>

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r259469.
+        https://bugs.webkit.org/show_bug.cgi?id=210066
+
+        Introduced media playback regression (Requested by perarne on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Deny mach lookup access to the runningboard service in
+        the WebContent process"
+        https://bugs.webkit.org/show_bug.cgi?id=209933
+        https://trac.webkit.org/changeset/259469
+
 2020-04-06  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

@@ -555 +555 @@
     (allow ipc-posix-sem-open))
 
-(deny mach-lookup (with telemetry-backtrace)
-    (global-name "com.apple.runningboard")
+(allow mach-lookup (with telemetry)
+    (global-name "com.apple.runningboard") ;; Needed by process assertion code (ProcessTaskStateObserver).
 )