Changeset 259614 in webkit

Timestamp:

Apr 6, 2020, 5:11:24 PM (6 years ago)

Author:

mark.lam@apple.com

Message:

REGRESSION: 68000 JSC tests failing.
​https://bugs.webkit.org/show_bug.cgi?id=210078
<rdar://problem/61364513>

Reviewed by Yusuke Suzuki.

The missing exception check is in jsc shell's GlobalObject::finishCreation().
Since this is just a debugging tool, and this exception will never be thrown in
practice, I've placated the validator by RELEASE_ASSERT'ing that the exception
will never be thrown.

• jsc.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-06  Mark Lam  <mark.lam@apple.com>
+
+        REGRESSION: 68000 JSC tests failing.
+        https://bugs.webkit.org/show_bug.cgi?id=210078
+        <rdar://problem/61364513>
+
+        Reviewed by Yusuke Suzuki.
+
+        The missing exception check is in jsc shell's GlobalObject::finishCreation().
+        Since this is just a debugging tool, and this exception will never be thrown in
+        practice, I've placated the validator by RELEASE_ASSERT'ing that the exception
+        will never be thrown.
+
+        * jsc.cpp:
+
 2020-04-06  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/JavaScriptCore/jsc.cpp

@@ -487 +487 @@
     void finishCreation(VM& vm, const Vector<String>& arguments)
     {
+        auto catchScope = DECLARE_CATCH_SCOPE(vm);
         Base::finishCreation(vm);
 
@@ -600 +601 @@
         JSFunction* IsHTMLDDAGetter = JSFunction::create(vm, this, 0, "IsHTMLDDA"_s, functionMakeMasquerader);
         dollar->putGetter(this, Identifier::fromString(vm, "IsHTMLDDA"), IsHTMLDDAGetter, static_cast<unsigned>(PropertyAttribute::Accessor));
-        
+        catchScope.releaseAssertNoException();
+
         JSObject* agent = JSFinalObject::create(vm, plainObjectStructure);
         dollar->putDirect(vm, Identifier::fromString(vm, "agent"), agent);