Changeset 259620 in webkit

Timestamp:

Apr 6, 2020, 7:16:48 PM (6 years ago)

Author:

ddkilzer@apple.com

Message:

Use-after-move of Vector<ManipulationToken> in TextManipulationController::observeParagraphs()
<​https://webkit.org/b/210086>

Reviewed by Ryosuke Niwa.

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

• Replace WTFMove() with std::exchange() to fix the clang static analyzer warning. For WTF::Vector, this has no change in behavior.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/TextManipulationController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-06  David Kilzer  <ddkilzer@apple.com>
+
+        Use-after-move of Vector<ManipulationToken> in TextManipulationController::observeParagraphs()
+        <https://webkit.org/b/210086>
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/TextManipulationController.cpp:
+        (WebCore::TextManipulationController::observeParagraphs):
+        - Replace WTFMove() with std::exchange() to fix the clang static
+          analyzer warning.  For WTF::Vector, this has no change in
+          behavior.
+
 2020-04-06  Jack Lee  <shihchieh_lee@apple.com>
 

trunk/Source/WebCore/editing/TextManipulationController.cpp

@@ -305 +305 @@
                     startOfCurrentParagraph = Position(&textNode, offsetOfNextNewLine + 1);
                 }
-                addItem(ManipulationItemData { startOfCurrentParagraph, endOfCurrentParagraph, nullptr, nullQName(), WTFMove(tokensInCurrentParagraph) });
+                addItem(ManipulationItemData { startOfCurrentParagraph, endOfCurrentParagraph, nullptr, nullQName(), std::exchange(tokensInCurrentParagraph, { }) });
                 startOfCurrentParagraph.clear();
             }