Changeset 259640 in webkit

Timestamp:

Apr 7, 2020, 9:09:43 AM (6 years ago)

Author:

youenn@apple.com

Message:

REGRESSION (r259383-259384): ASSERTION FAILED: 'Completion handler should always be called' seen with http/wpt/service-workers/service-worker-different-process.https.html
​https://bugs.webkit.org/show_bug.cgi?id=209977

Reviewed by Chris Dumez.

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::~AuxiliaryProcessProxy):
In case AuxiliaryProcessProxy has some enqueued messages but process crashes on launch for instance,
we should call the completion handlers and fail.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/AuxiliaryProcessProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-07  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION (r259383-259384): ASSERTION FAILED: 'Completion handler should always be called' seen with http/wpt/service-workers/service-worker-different-process.https.html
+        https://bugs.webkit.org/show_bug.cgi?id=209977
+
+        Reviewed by Chris Dumez.
+
+        * UIProcess/AuxiliaryProcessProxy.cpp:
+        (WebKit::AuxiliaryProcessProxy::~AuxiliaryProcessProxy):
+        In case AuxiliaryProcessProxy has some enqueued messages but process crashes on launch for instance,
+        we should call the completion handlers and fail.
+
 2020-04-07  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

@@ -49 +49 @@
         m_processLauncher = nullptr;
     }
+    auto pendingMessages = WTFMove(m_pendingMessages);
+    for (auto& pendingMessage : pendingMessages) {
+        if (pendingMessage.asyncReplyInfo)
+            pendingMessage.asyncReplyInfo->first(nullptr);
+    }
 }