Changeset 259643 in webkit

Timestamp:

Apr 7, 2020, 9:38:32 AM (6 years ago)

Author:

aboya@igalia.com

Message:

[GStreamer] Log a warning if playbin is not found
​https://bugs.webkit.org/show_bug.cgi?id=210112

Reviewed by Philippe Normand.

I spent quite a bit of time looking in the debugger for what ended up
being a trivial configuration issue because there was no logging
showing any obvious problem. Let's add it.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-07  Alicia Boya García  <aboya@igalia.com>
+
+        [GStreamer] Log a warning if playbin is not found
+        https://bugs.webkit.org/show_bug.cgi?id=210112
+
+        Reviewed by Philippe Normand.
+
+        I spent quite a bit of time looking in the debugger for what ended up
+        being a trivial configuration issue because there was no logging
+        showing any obvious problem. Let's add it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::isAvailable):
+
 2020-04-07  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -549 +549 @@
     // FIXME: This has not been updated for the playbin3 switch.
     GRefPtr<GstElementFactory> factory = adoptGRef(gst_element_factory_find("playbin"));
+    if (!factory)
+        GST_WARNING("Couldn't find a factory for the playbin element. Media playback will be disabled.");
     return factory;
 }