Changeset 259651 in webkit

Timestamp:

Apr 7, 2020, 11:40:07 AM (6 years ago)

Author:

Chris Dumez

Message:

documentFragment.getElementById() should not work for empty-string IDs
​https://bugs.webkit.org/show_bug.cgi?id=210111

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Import test coverage from upstream WPT.

• web-platform-tests/dom/nodes/DocumentFragment-getElementById-expected.txt: Added.
• web-platform-tests/dom/nodes/DocumentFragment-getElementById.html: Added.

Source/WebCore:

Make sure that getElementById() returns null when given an empty string ID:

• ​https://dom.spec.whatwg.org/#concept-id

Test: imported/w3c/web-platform-tests/dom/nodes/DocumentFragment-getElementById.html

• dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::getElementById const):

• dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DocumentFragment-getElementById-expected.txt (added)
• LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DocumentFragment-getElementById.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/DocumentFragment.cpp (modified) (1 diff)
• Source/WebCore/dom/TreeScope.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-04-07  Chris Dumez  <cdumez@apple.com>
+
+        documentFragment.getElementById() should not work for empty-string IDs
+        https://bugs.webkit.org/show_bug.cgi?id=210111
+
+        Reviewed by Geoffrey Garen.
+
+        Import test coverage from upstream WPT.
+
+        * web-platform-tests/dom/nodes/DocumentFragment-getElementById-expected.txt: Added.
+        * web-platform-tests/dom/nodes/DocumentFragment-getElementById.html: Added.
+
 2020-04-06  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-07  Chris Dumez  <cdumez@apple.com>
+
+        documentFragment.getElementById() should not work for empty-string IDs
+        https://bugs.webkit.org/show_bug.cgi?id=210111
+
+        Reviewed by Geoffrey Garen.
+
+        Make sure that getElementById() returns null when given an empty string ID:
+        - https://dom.spec.whatwg.org/#concept-id
+
+        Test: imported/w3c/web-platform-tests/dom/nodes/DocumentFragment-getElementById.html
+
+        * dom/DocumentFragment.cpp:
+        (WebCore::DocumentFragment::getElementById const):
+        * dom/TreeScope.cpp:
+        (WebCore::TreeScope::getElementById const):
+
 2020-04-07  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebCore/dom/DocumentFragment.cpp

@@ -96 +96 @@
 Element* DocumentFragment::getElementById(const AtomString& id) const
 {
-    if (id.isNull())
+    if (id.isEmpty())
         return nullptr;
 

trunk/Source/WebCore/dom/TreeScope.cpp

@@ -101 +101 @@
 Element* TreeScope::getElementById(const AtomString& elementId) const
 {
-    if (elementId.isNull())
+    if (elementId.isEmpty())
         return nullptr;
     if (!m_elementsById)