Changeset 259743 in webkit

Timestamp:

Apr 8, 2020, 12:12:10 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unused WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary and WebProcessPool::sendToOneProcess
​https://bugs.webkit.org/show_bug.cgi?id=210199

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-04-08
Reviewed by Alex Christensen.

Remove unused functions.

• UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary): Deleted.
(WebKit::WebProcessPool::sendToOneProcess): Deleted.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessPool.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-08  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Remove unused WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary and WebProcessPool::sendToOneProcess
+        https://bugs.webkit.org/show_bug.cgi?id=210199
+
+        Reviewed by Alex Christensen.
+
+        Remove unused functions.
+
+        * UIProcess/WebProcessPool.h:
+        (WebKit::WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary): Deleted.
+        (WebKit::WebProcessPool::sendToOneProcess): Deleted.
+
 2020-04-08  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.h

@@ -193 +193 @@
     template<typename T> void sendToAllProcesses(const T& message);
     template<typename T> void sendToAllProcessesForSession(const T& message, PAL::SessionID);
-    template<typename T> void sendToAllProcessesRelaunchingThemIfNecessary(const T& message);
-    template<typename T> void sendToOneProcess(T&& message);
 
     // Sends the message to WebProcess or NetworkProcess as approporiate for current process model.
@@ -845 +843 @@
 }
 
-template<typename T>
-void WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary(const T& message)
-{
-    // FIXME (Multi-WebProcess): WebProcessPool doesn't track processes that have exited, so it cannot relaunch these. Perhaps this functionality won't be needed in this mode.
-    sendToAllProcesses(message);
-}
-
-template<typename T>
-void WebProcessPool::sendToOneProcess(T&& message)
-{
-    bool messageSent = false;
-    size_t processCount = m_processes.size();
-    for (size_t i = 0; i < processCount; ++i) {
-        WebProcessProxy* process = m_processes[i].get();
-        if (process->canSendMessage()) {
-            process->send(std::forward<T>(message), 0);
-            messageSent = true;
-            break;
-        }
-    }
-
-    if (!messageSent) {
-        prewarmProcess();
-        RefPtr<WebProcessProxy> process = m_processes.last();
-        if (process->canSendMessage())
-            process->send(std::forward<T>(message), 0);
-    }
-}
-
 } // namespace WebKit