⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 259764 in webkit


Ignore:
Timestamp:
Apr 8, 2020, 3:57:51 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Release WebGLLayer earlier in ~GraphicsContextGLOpenGL
​https://bugs.webkit.org/show_bug.cgi?id=210213

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-04-08
Reviewed by Dean Jackson.

Release WebGLLayer earlier and remove public context property,
which is no longer called.

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

  • platform/graphics/cocoa/WebGLLayer.h:
  • platform/graphics/cocoa/WebGLLayer.mm:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r259762 r259764  
     12020-04-08  Kenneth Russell  <kbr@chromium.org>
     2
     3        Release WebGLLayer earlier in ~GraphicsContextGLOpenGL
     4        https://bugs.webkit.org/show_bug.cgi?id=210213
     5
     6        Reviewed by Dean Jackson.
     7
     8        Release WebGLLayer earlier and remove public context property,
     9        which is no longer called.
     10
     11        * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
     12        (WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
     13        * platform/graphics/cocoa/WebGLLayer.h:
     14        * platform/graphics/cocoa/WebGLLayer.mm:
     15
    1162020-04-08  Daniel Bates  <dabates@apple.com>
    217

  • trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm

    r259482 r259764  
    583583#endif
    584584
     585        // Release the WebGLLayer before destroying the underlying
     586        // context to enable it to do any necessary cleanups.
     587        m_webGLLayer = nullptr;
     588
    585589#if USE(OPENGL_ES)
    586590        [EAGLContext setCurrentContext:0];
    … …  
    593597        EGL_DestroyContext(m_displayObj, m_contextObj);
    594598#endif
    595         [m_webGLLayer setContext:nullptr];
    596599    }
    597600

  • trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h

    r254241 r259764  
    6767}
    6868
    69 @property (nonatomic) NakedPtr<WebCore::GraphicsContextGLOpenGL> context;
    70 
    7169- (id)initWithGraphicsContextGL:(NakedPtr<WebCore::GraphicsContextGLOpenGL>)context;
    7270

  • trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm

    r259737 r259764  
    6060@implementation WebGLLayer
    6161
    62 @synthesize context=_context;
    63 
    6462-(id)initWithGraphicsContextGL:(NakedPtr<WebCore::GraphicsContextGLOpenGL>)context
    6563{
Note: See TracChangeset for help on using the changeset viewer.