Changeset 259765 in webkit

Timestamp:

Apr 8, 2020, 4:50:38 PM (6 years ago)

Author:

beidson@apple.com

Message:

Handle [PDFDocument initWithProvider:] returning nil
<rdar://problem/61482395> and ​https://bugs.webkit.org/show_bug.cgi?id=210224

Reviewed by Geoff Garen.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::threadEntry): Treat a nil PDFDocument as "non-linearized, fallback to normal loading"

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/PDF/PDFPlugin.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-08  Brady Eidson  <beidson@apple.com>
+
+        Handle [PDFDocument initWithProvider:] returning nil
+        <rdar://problem/61482395> and https://bugs.webkit.org/show_bug.cgi?id=210224
+
+        Reviewed by Geoff Garen.
+
+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
+        (WebKit::PDFPlugin::threadEntry): Treat a nil PDFDocument as "non-linearized, fallback to normal loading"
+
 2020-04-08  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

@@ -868 +868 @@
     m_backgroundThreadDocument = adoptNS([[pdfDocumentClass() alloc] initWithProvider:dataProvider.get()]);
 
+    // [PDFDocument initWithProvider:] will return nil in cases where the PDF is non-linearized.
+    // In those cases we'll just keep buffering the entire PDF on the main thread.
+    if (!m_backgroundThreadDocument)
+        return;
+
     if (!m_incrementalPDFLoadingEnabled) {
         m_backgroundThreadDocument = nil;