⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 259787 in webkit


Ignore:
Timestamp:
Apr 9, 2020, 3:05:58 AM (6 years ago)
Author:
aakash_jain@apple.com
Message:

[ews] rename CompileWebKitToT to CompileWebKitWithoutPatch
​https://bugs.webkit.org/show_bug.cgi?id=210190

Reviewed by Alex Christensen.

  • BuildSlaveSupport/ews-build/steps.py: Renamed CompileWebKitToT to CompileWebKitWithoutPatch.

(CompileWebKit.evaluateCommand):
(CompileWebKitWithoutPatch):
(AnalyzeCompileWebKitResults.start):
(ReRunWebKitTests.evaluateCommand):
(ReRunAPITests.evaluateCommand):
(CompileWebKitToT): Deleted.
(CompileWebKitToT.doStepIf): Deleted.
(CompileWebKitToT.hideStepIf): Deleted.
(CompileWebKitToT.evaluateCommand): Deleted.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-build/steps.py

    r259719 r259787  
    13111311                steps_to_add.append(CompileJSCToT())
    13121312            else:
    1313                 steps_to_add.append(CompileWebKitToT())
     1313                steps_to_add.append(CompileWebKitWithoutPatch())
    13141314            steps_to_add.append(AnalyzeCompileWebKitResults())
    13151315            # Using a single addStepsAfterCurrentStep because of https://github.com/buildbot/buildbot/issues/4874
    … …  
    13281328
    13291329
    1330 class CompileWebKitToT(CompileWebKit):
     1330class CompileWebKitWithoutPatch(CompileWebKit):
    13311331    name = 'compile-webkit-tot'
    13321332    haltOnFailure = False
    … …  
    13481348
    13491349    def start(self):
    1350         compile_tot_step = CompileWebKitToT.name
     1350        compile_tot_step = CompileWebKitWithoutPatch.name
    13511351        if self.getProperty('group') == 'jsc':
    13521352            compile_tot_step = CompileJSCToT.name
    … …  
    18191819                                                UnApplyPatchIfRequired(),
    18201820                                                ValidatePatch(verifyBugClosed=False, addURLs=False),
    1821                                                 CompileWebKitToT(),
     1821                                                CompileWebKitWithoutPatch(),
    18221822                                                ValidatePatch(verifyBugClosed=False, addURLs=False),
    18231823                                                KillOldProcesses(),
    … …  
    21752175            elif platform == 'gtk':
    21762176                steps_to_add.append(InstallGtkDependencies())
    2177             steps_to_add.append(CompileWebKitToT())
     2177            steps_to_add.append(CompileWebKitWithoutPatch())
    21782178            steps_to_add.append(ValidatePatch(verifyBugClosed=False, addURLs=False))
    21792179            steps_to_add.append(KillOldProcesses())

  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r259719 r259787  
    3939                   CheckOutSource, CheckOutSpecificRevision, CheckPatchRelevance, CheckPatchStatusOnEWSQueues, CheckStyle,
    4040                   CleanBuild, CleanUpGitIndexLock, CleanWorkingDirectory, CompileJSC, CompileJSCToT, CompileWebKit,
    41                    CompileWebKitToT, ConfigureBuild, CreateLocalGITCommit,
     41                   CompileWebKitWithoutPatch, ConfigureBuild, CreateLocalGITCommit,
    4242                   DownloadBuiltProduct, DownloadBuiltProductFromMaster, ExtractBuiltProduct, ExtractTestResults,
    4343                   FindModifiedChangeLogs, InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses,
    … …  
    10001000
    10011001
    1002 class TestCompileWebKitToT(BuildStepMixinAdditions, unittest.TestCase):
    1003     def setUp(self):
    1004         self.longMessage = True
    1005         return self.setUpBuildStep()
    1006 
    1007     def tearDown(self):
    1008         return self.tearDownBuildStep()
    1009 
    1010     def test_success(self):
    1011         self.setupStep(CompileWebKitToT())
     1002class TestCompileWebKitWithoutPatch(BuildStepMixinAdditions, unittest.TestCase):
     1003    def setUp(self):
     1004        self.longMessage = True
     1005        return self.setUpBuildStep()
     1006
     1007    def tearDown(self):
     1008        return self.tearDownBuildStep()
     1009
     1010    def test_success(self):
     1011        self.setupStep(CompileWebKitWithoutPatch())
    10121012        self.setProperty('fullPlatform', 'ios-simulator-11')
    10131013        self.setProperty('configuration', 'release')
    … …  
    10241024
    10251025    def test_failure(self):
    1026         self.setupStep(CompileWebKitToT())
     1026        self.setupStep(CompileWebKitWithoutPatch())
    10271027        self.setProperty('fullPlatform', 'mac-sierra')
    10281028        self.setProperty('configuration', 'debug')
    … …  
    10401040
    10411041    def test_skip(self):
    1042         self.setupStep(CompileWebKitToT())
     1042        self.setupStep(CompileWebKitWithoutPatch())
    10431043        self.setProperty('fullPlatform', 'ios-simulator-11')
    10441044        self.setProperty('configuration', 'release')
    … …  
    10591059        previous_steps = [
    10601060            mock_step(CompileWebKit(), results=FAILURE),
    1061             mock_step(CompileWebKitToT(), results=SUCCESS),
     1061            mock_step(CompileWebKitWithoutPatch(), results=SUCCESS),
    10621062        ]
    10631063        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
    … …  
    10721072        previous_steps = [
    10731073            mock_step(CompileWebKit(), results=FAILURE),
    1074             mock_step(CompileWebKitToT(), results=SUCCESS),
     1074            mock_step(CompileWebKitWithoutPatch(), results=SUCCESS),
    10751075        ]
    10761076        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
    … …  
    10861086        previous_steps = [
    10871087            mock_step(CompileWebKit(), results=FAILURE),
    1088             mock_step(CompileWebKitToT(), results=FAILURE),
     1088            mock_step(CompileWebKitWithoutPatch(), results=FAILURE),
    10891089        ]
    10901090        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)

  • trunk/Tools/ChangeLog

    r259772 r259787  
     12020-04-09  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews] rename CompileWebKitToT to CompileWebKitWithoutPatch
     4        https://bugs.webkit.org/show_bug.cgi?id=210190
     5
     6        Reviewed by Alex Christensen.
     7
     8        * BuildSlaveSupport/ews-build/steps.py: Renamed CompileWebKitToT to CompileWebKitWithoutPatch.
     9        (CompileWebKit.evaluateCommand):
     10        (CompileWebKitWithoutPatch):
     11        (AnalyzeCompileWebKitResults.start):
     12        (ReRunWebKitTests.evaluateCommand):
     13        (ReRunAPITests.evaluateCommand):
     14        (CompileWebKitToT): Deleted.
     15        (CompileWebKitToT.doStepIf): Deleted.
     16        (CompileWebKitToT.hideStepIf): Deleted.
     17        (CompileWebKitToT.evaluateCommand): Deleted.
     18        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
     19
    1202020-04-08  Alex Christensen  <achristensen@webkit.org>
    221
Note: See TracChangeset for help on using the changeset viewer.