Changeset 259813 in webkit

Timestamp:

Apr 9, 2020, 12:23:10 PM (6 years ago)

Author:

Antti Koivisto

Message:

Removed unused fields and functions from StylePropertyShorthand
​https://bugs.webkit.org/show_bug.cgi?id=210279

Reviewed by Darin Adler.

• css/StylePropertyShorthand.cpp:

(WebCore::borderAbridgedShorthand): Deleted.

• css/StylePropertyShorthand.h:

(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties const):
(WebCore::StylePropertyShorthand::propertiesForInitialization const): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StylePropertyShorthand.cpp (modified) (1 diff)
• css/StylePropertyShorthand.h (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-09  Antti Koivisto  <antti@apple.com>
+
+        Removed unused fields and functions from StylePropertyShorthand
+        https://bugs.webkit.org/show_bug.cgi?id=210279
+
+        Reviewed by Darin Adler.
+
+        * css/StylePropertyShorthand.cpp:
+        (WebCore::borderAbridgedShorthand): Deleted.
+        * css/StylePropertyShorthand.h:
+        (WebCore::StylePropertyShorthand::StylePropertyShorthand):
+        (WebCore::StylePropertyShorthand::properties const):
+        (WebCore::StylePropertyShorthand::propertiesForInitialization const): Deleted.
+
 2020-04-08  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/css/StylePropertyShorthand.cpp

@@ -25 +25 @@
 
 namespace WebCore {
-
-StylePropertyShorthand borderAbridgedShorthand()
-{
-    static const CSSPropertyID borderAbridgedProperties[] = { CSSPropertyBorderWidth, CSSPropertyBorderStyle, CSSPropertyBorderColor };
-    static const StylePropertyShorthand propertiesForInitialization[] = { borderWidthShorthand(), borderStyleShorthand(), borderColorShorthand() };
-    return StylePropertyShorthand(CSSPropertyBorder, borderAbridgedProperties, propertiesForInitialization);
-}
 
 StylePropertyShorthand animationShorthandForParsing()

trunk/Source/WebCore/css/StylePropertyShorthand.h

@@ -32 +32 @@
 
     template<unsigned numProperties>
-    StylePropertyShorthand(CSSPropertyID id, const CSSPropertyID (&properties)[numProperties], const StylePropertyShorthand* propertiesForInitialization = nullptr)
+    StylePropertyShorthand(CSSPropertyID id, const CSSPropertyID (&properties)[numProperties])
         : m_properties(properties)
-        , m_propertiesForInitialization(propertiesForInitialization)
         , m_length(numProperties)
         , m_shorthandID(id)
@@ -44 +43 @@
 
     const CSSPropertyID* properties() const { return m_properties; }
-    const StylePropertyShorthand* propertiesForInitialization() const { return m_propertiesForInitialization; }
     unsigned length() const { return m_length; }
     CSSPropertyID id() const { return m_shorthandID; }
@@ -50 +48 @@
 private:
     const CSSPropertyID* m_properties { nullptr };
-    const StylePropertyShorthand* m_propertiesForInitialization { nullptr };
     unsigned m_length { 0 };
     CSSPropertyID m_shorthandID { CSSPropertyInvalid };
@@ -58 +55 @@
 StylePropertyShorthand animationShorthandForParsing();
 StylePropertyShorthand transitionShorthandForParsing();
-StylePropertyShorthand borderAbridgedShorthand();
 
 // Returns empty value if the property is not a shorthand.