Changeset 259815 in webkit

Timestamp:

Apr 9, 2020, 12:42:02 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Add unit tests to ensure that step names are valid identifier
​https://bugs.webkit.org/show_bug.cgi?id=210289

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestStepNameShouldBeValidIdentifier):
(TestStepNameShouldBeValidIdentifier.test_step_names_are_valid): unit-test to validate step names.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -21 +21 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import inspect
 import operator
 import os
@@ -30 +31 @@
 from buildbot.test.fake.remotecommand import Expect, ExpectRemoteRef, ExpectShell
 from buildbot.test.util.steps import BuildStepMixin
+from buildbot.util import identifiers as buildbot_identifiers
 from mock import call
 from twisted.internet import error, reactor
@@ -203 +205 @@
             writer.remote_utime(timestamp)
     return behavior
+
+
+class TestStepNameShouldBeValidIdentifier(BuildStepMixinAdditions, unittest.TestCase):
+    def test_step_names_are_valid(self):
+        import steps
+        build_step_classes = inspect.getmembers(steps, inspect.isclass)
+        for build_step in build_step_classes:
+            if 'name' in vars(build_step[1]):
+                name = build_step[1].name
+                self.assertFalse(' ' in name, 'step name "{}" contain space.'.format(name))
+                self.assertTrue(buildbot_identifiers.ident_re.match(name), 'step name "{}" is not a valid buildbot identifier.'.format(name))
 
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-09  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Add unit tests to ensure that step names are valid identifier
+        https://bugs.webkit.org/show_bug.cgi?id=210289
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestStepNameShouldBeValidIdentifier):
+        (TestStepNameShouldBeValidIdentifier.test_step_names_are_valid): unit-test to validate step names.
+
 2020-04-09  Jonathan Bedard  <jbedard@apple.com>