⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 259826 in webkit


Ignore:
Timestamp:
Apr 9, 2020, 1:51:59 PM (6 years ago)
Author:
Keith Rollin
Message:

Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
​https://bugs.webkit.org/show_bug.cgi?id=210250
<rdar://problem/61502270>

Reviewed by Jonathan Bedard.

When building with the public version of Xcode 11.4, with XCBuild
enabled, and targeting the iOS device, some build targets issue an
error like:

error: An empty identity is not valid when signing a binary for

the product type 'Command-line Tool'. (in target 'yasm' from
project 'libwebrtc')

A comment in <rdar://problem/47092353> suggests setting
ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when
building with the public Xcode, establish that setting for the
affected targets.

Source/ThirdParty/libwebrtc:

  • Configurations/Base.xcconfig:

Source/WebCore:

No new tests -- no changed functionality.

  • Configurations/WebCoreTestShim.xcconfig:
  • Configurations/WebCoreTestSupport.xcconfig:

Source/WebKit:

  • Configurations/GPUService.xcconfig:
  • Configurations/NetworkService.xcconfig:
  • Configurations/PluginProcessShim.xcconfig:
  • Configurations/PluginService.64.xcconfig:
  • Configurations/SecItemShim.xcconfig:
  • Configurations/WebContentService.xcconfig:

Tools:

With this change, we can also remove
IDEProvisioningProfileSupportRelaxed=YES from webkitdirs.pm.

  • Scripts/webkitdirs.pm:

(XcodeOptions):

  • TestWebKitAPI/Configurations/TestWTF.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/ThirdParty/libwebrtc/ChangeLog

    r259726 r259826  
     12020-04-09  Keith Rollin  <krollin@apple.com>
     2
     3        Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
     4        https://bugs.webkit.org/show_bug.cgi?id=210250
     5        <rdar://problem/61502270>
     6
     7        Reviewed by Jonathan Bedard.
     8
     9        When building with the public version of Xcode 11.4, with XCBuild
     10        enabled, and targeting the iOS device, some build targets issue an
     11        error like:
     12
     13            error: An empty identity is not valid when signing a binary for
     14                the product type 'Command-line Tool'. (in target 'yasm' from
     15                project 'libwebrtc')
     16
     17        A comment in <rdar://problem/47092353> suggests setting
     18        ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when
     19        building with the public Xcode, establish that setting for the
     20        affected targets.
     21
     22        * Configurations/Base.xcconfig:
     23
    1242020-04-08  Truitt Savell  <tsavell@apple.com>
    225

  • trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig

    r259466 r259826  
    6161STRIP_INSTALLED_PRODUCT = NO;
    6262WARNING_CFLAGS = -Wexit-time-destructors -Wglobal-constructors -Wthread-safety;
     63
     64ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     65ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     66ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     67ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);
    6368
    6469SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx;

  • trunk/Source/WebCore/ChangeLog

    r259825 r259826  
     12020-04-09  Keith Rollin  <krollin@apple.com>
     2
     3        Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
     4        https://bugs.webkit.org/show_bug.cgi?id=210250
     5        <rdar://problem/61502270>
     6
     7        Reviewed by Jonathan Bedard.
     8
     9        When building with the public version of Xcode 11.4, with XCBuild
     10        enabled, and targeting the iOS device, some build targets issue an
     11        error like:
     12
     13            error: An empty identity is not valid when signing a binary for
     14                the product type 'Command-line Tool'. (in target 'yasm' from
     15                project 'libwebrtc')
     16
     17        A comment in <rdar://problem/47092353> suggests setting
     18        ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when
     19        building with the public Xcode, establish that setting for the
     20        affected targets.
     21
     22        No new tests -- no changed functionality.
     23
     24        * Configurations/WebCoreTestShim.xcconfig:
     25        * Configurations/WebCoreTestSupport.xcconfig:
     26
    1272020-04-09  Rob Buis  <rbuis@igalia.com>
    228

  • trunk/Source/WebCore/Configurations/WebCoreTestShim.xcconfig

    r230836 r259826  
    4444OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
    4545OTHER_LDFLAGS[sdk=macosx*] = $(ASAN_OTHER_LDFLAGS) -framework Carbon;
     46
     47ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     48ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     49ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     50ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

    r254551 r259826  
    6363OTHER_LDFLAGS[sdk=iphonesimulator*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility $(LIBWEBRTC_LDFLAGS);
    6464SECT_ORDER_FLAGS = ;
     65
     66ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     67ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     68ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     69ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/ChangeLog

    r259824 r259826  
     12020-04-09  Keith Rollin  <krollin@apple.com>
     2
     3        Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
     4        https://bugs.webkit.org/show_bug.cgi?id=210250
     5        <rdar://problem/61502270>
     6
     7        Reviewed by Jonathan Bedard.
     8
     9        When building with the public version of Xcode 11.4, with XCBuild
     10        enabled, and targeting the iOS device, some build targets issue an
     11        error like:
     12
     13            error: An empty identity is not valid when signing a binary for
     14                the product type 'Command-line Tool'. (in target 'yasm' from
     15                project 'libwebrtc')
     16
     17        A comment in <rdar://problem/47092353> suggests setting
     18        ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when
     19        building with the public Xcode, establish that setting for the
     20        affected targets.
     21
     22        * Configurations/GPUService.xcconfig:
     23        * Configurations/NetworkService.xcconfig:
     24        * Configurations/PluginProcessShim.xcconfig:
     25        * Configurations/PluginService.64.xcconfig:
     26        * Configurations/SecItemShim.xcconfig:
     27        * Configurations/WebContentService.xcconfig:
     28
    1292020-04-09  Jacob Uphoff  <jacob_uphoff@apple.com>
    230

  • trunk/Source/WebKit/Configurations/GPUService.xcconfig

    r253098 r259826  
    3030
    3131OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
     32
     33ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     34ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     35ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     36ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/Configurations/NetworkService.xcconfig

    r248164 r259826  
    3131OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
    3232OTHER_LDFLAGS[sdk=macosx*] = $(inherited) $(BUILT_PRODUCTS_DIR)/SecItemShim.dylib;
     33
     34ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     35ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     36ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     37ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig

    r230698 r259826  
    3636
    3737OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_QUARTZCORE_LDFLAGS);
     38
     39ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     40ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     41ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     42ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/Configurations/PluginService.64.xcconfig

    r248164 r259826  
    3939
    4040SKIP_INSTALL[sdk=iphone*] = YES;
     41
     42ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     43ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     44ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     45ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/Configurations/SecItemShim.xcconfig

    r194022 r259826  
    2828OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM);
    2929OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = -framework Security;
     30
     31ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     32ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     33ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     34ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Source/WebKit/Configurations/WebContentService.xcconfig

    r248164 r259826  
    5151RUNLOOP_TYPE_MACOS_BEFORE_1014 = _NSApplicationMain;
    5252RUNLOOP_TYPE_MACOS_SINCE_1014 = _WebKit;
     53
     54ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     55ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     56ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     57ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Tools/ChangeLog

    r259819 r259826  
     12020-04-09  Keith Rollin  <krollin@apple.com>
     2
     3        Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
     4        https://bugs.webkit.org/show_bug.cgi?id=210250
     5        <rdar://problem/61502270>
     6
     7        Reviewed by Jonathan Bedard.
     8
     9        When building with the public version of Xcode 11.4, with XCBuild
     10        enabled, and targeting the iOS device, some build targets issue an
     11        error like:
     12
     13            error: An empty identity is not valid when signing a binary for
     14                the product type 'Command-line Tool'. (in target 'yasm' from
     15                project 'libwebrtc')
     16
     17        A comment in <rdar://problem/47092353> suggests setting
     18        ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when
     19        building with the public Xcode, establish that setting for the
     20        affected targets.
     21
     22        With this change, we can also remove
     23        IDEProvisioningProfileSupportRelaxed=YES from webkitdirs.pm.
     24
     25        * Scripts/webkitdirs.pm:
     26        (XcodeOptions):
     27        * TestWebKitAPI/Configurations/TestWTF.xcconfig:
     28        * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
     29
    1302020-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
    231

  • trunk/Tools/Scripts/webkitdirs.pm

    r259726 r259826  
    915915
    916916    if (willUseIOSDeviceSDK() || willUseWatchDeviceSDK() || willUseAppleTVDeviceSDK()) {
    917         push @options, "-IDEProvisioningProfileSupportRelaxed=YES";
    918917        push @options, "ENABLE_BITCODE=NO";
    919918        if (hasIOSDevelopmentCertificate()) {

  • trunk/Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig

    r246282 r259826  
    3939
    4040STRIP_STYLE = debugging;
     41
     42ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     43ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     44ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     45ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);

  • trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig

    r257614 r259826  
    8181CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
    8282INFOPLIST_FILE = $(SRCROOT)/Info.plist;
     83
     84ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
     85ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
     86ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_NO = NO;
     87ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_YES = $(ENTITLEMENTS_REQUIRED);
Note: See TracChangeset for help on using the changeset viewer.