Changeset 259831 in webkit

Timestamp:

Apr 9, 2020, 2:50:49 PM (6 years ago)

Author:

dbates@webkit.org

Message:

[iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
​https://bugs.webkit.org/show_bug.cgi?id=210305
<rdar://problem/61539886>

Fix up the test. All sub-tests are expected to find editable elements. This is a result
of a last minute realization that I need to iterate over all the hit views instead of just
the frontmost one because the search rect can overlap multiple layers: See "iterate over all
the hit views" in <​https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
true that the search rect contains an editable element even though that element may be occluded
by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
negatives are not.

• editing/editable-region/hit-test-overlap-expected.txt:
• editing/editable-region/hit-test-overlap.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• editing/editable-region/hit-test-overlap-expected.txt (modified) (1 diff)
• editing/editable-region/hit-test-overlap.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-04-09  Daniel Bates  <dabates@apple.com>
+
+        [iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
+        https://bugs.webkit.org/show_bug.cgi?id=210305
+        <rdar://problem/61539886>
+
+        Fix up the test. All sub-tests are expected to find editable elements. This is a result
+        of a last minute realization that I need to iterate over all the hit views instead of just
+        the frontmost one because the search rect can overlap multiple layers: See "iterate over all
+        the hit views" in <https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
+        requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
+        true that the search rect contains an editable element even though that element may be occluded
+        by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
+        negatives are not.
+
+        * editing/editable-region/hit-test-overlap-expected.txt:
+        * editing/editable-region/hit-test-overlap.html:
+
 2020-04-09  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt

@@ -10 +10 @@
 
 Composited overlap:
-PASS (x = 29, y = 343, width = 251, height = 201) does not contain editable elements.
-PASS (x = 270, y = 400, width = 10, height = 10) does not contain editable elements.
+PASS (x = 29, y = 343, width = 251, height = 201) contains editable elements.
+PASS (x = 270, y = 400, width = 10, height = 10) contains editable elements.
 PASS (x = 281, y = 343, width = 249, height = 201) contains editable elements.
 PASS successfullyParsed is true

trunk/LayoutTests/editing/editable-region/hit-test-overlap.html

@@ -91 +91 @@
     overlapper = container.querySelector(".overlapper");
     borderLength = parseInt(containerComputedStyle.borderLeftWidth, 10); // Assumes uniform border width
-    await shouldNotHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
-    await shouldNotHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
+    await shouldHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
+    await shouldHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
     await shouldHaveEditableElementsInRect(container.offsetLeft + overlapper.offsetWidth + borderLength, container.offsetTop + borderLength, container.offsetWidth - overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);