Changeset 259834 in webkit

Timestamp:

Apr 9, 2020, 3:17:29 PM (6 years ago)

Author:

Andres Gonzalez

Message:

WKAccessibilityRootObject must run on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=210306

Reviewed by Chris Fleizach.

WKAccessibilityRootObject needs to run on the main thread because makes
calls into Document and Page. So reverting the change to make it run on
the AX thread. This means that we cannot simulate getting the root
object on the secondary thread at the moment, as it would with an
accessibility client that supports isolated tree mode. So it is a
tradeoff made for the time being to be able to make progress in testing
the rest of the functionality of AXIsolatedTree/Object.

• WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::accessibleElementById):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-09  Andres Gonzalez  <andresg_22@apple.com>
+
+        WKAccessibilityRootObject must run on the main thread.
+        https://bugs.webkit.org/show_bug.cgi?id=210306
+
+        Reviewed by Chris Fleizach.
+
+        WKAccessibilityRootObject needs to run on the main thread because makes
+        calls into Document and Page. So reverting the change to make it run on
+        the AX thread. This means that we cannot simulate getting the root
+        object on the secondary thread at the moment, as it would with an
+        accessibility client that supports isolated tree mode. So it is a
+        tradeoff made for the time being to be able to make progress in testing
+        the rest of the functionality of AXIsolatedTree/Object.
+
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
+        (WTR::AccessibilityController::accessibleElementById):
+
 2020-04-09  David Kilzer  <ddkilzer@apple.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm

@@ -98 +98 @@
 {
     WKBundlePageRef page = InjectedBundle::singleton().page()->page();
-    PlatformUIElement root = nullptr;
-
-    executeOnAXThreadIfPossible([&page, &root] {
-        root = static_cast<PlatformUIElement>(WKAccessibilityRootObject(page));
-    });
+    PlatformUIElement root = static_cast<PlatformUIElement>(WKAccessibilityRootObject(page));
 
     id result;