Changeset 259841 in webkit

Timestamp:

Apr 9, 2020, 5:28:11 PM (6 years ago)

Author:

Devin Rousso

Message:

Don't emit the rhs twice in AssignResolveNode
​https://bugs.webkit.org/show_bug.cgi?id=210312

Reviewed by Yusuke Suzuki.

• bytecompiler/NodesCodegen.cpp:

(JSC::AssignResolveNode::emitBytecode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecompiler/NodesCodegen.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-09  Devin Rousso  <drousso@apple.com>
+
+        Don't emit the rhs twice in `AssignResolveNode`
+        https://bugs.webkit.org/show_bug.cgi?id=210312
+
+        Reviewed by Yusuke Suzuki.
+
+        * bytecompiler/NodesCodegen.cpp:
+        (JSC::AssignResolveNode::emitBytecode):
+
 2020-04-09  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -2911 +2911 @@
     if (dst == generator.ignoredResult())
         dst = 0;
-    RefPtr<RegisterID> result = generator.emitNode(dst, m_right);
+    RefPtr<RegisterID> result = generator.emitNode(dst, m_right); // Execute side effects first.
     if (isReadOnly) {
-        RegisterID* result = generator.emitNode(dst, m_right); // Execute side effects first.
         bool threwException = generator.emitReadOnlyExceptionIfNeeded(var);
         if (threwException)
-            return result;
+            return result.get();
     }
     generator.emitExpressionInfo(divot(), divotStart(), divotEnd());