Changeset 262586 in webkit

Timestamp:

Jun 4, 2020 4:56:16 PM (4 years ago)

Author:

Brent Fulgham

Message:

Reduce telemetry and report generation for WebContent Process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=212779
<rdar://problem/63769879>

Reviewed by Per Arne Vollan.

This patch cleans up a set of telemetry and reports generated during normal
WebKit operation. Now that we understand the uses of these XPC services, we
can reduce the logging traffic.

This is important to do now, since generating the telemetry and reports has
a non-zero power cost.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (modified) (1 diff)
• WebProcess/com.apple.WebProcess.sb.in (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-04  Brent Fulgham  <bfulgham@apple.com>
+
+        Reduce telemetry and report generation for WebContent Process sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=212779
+        <rdar://problem/63769879>
+
+        Reviewed by Per Arne Vollan.
+
+        This patch cleans up a set of telemetry and reports generated during normal
+        WebKit operation. Now that we understand the uses of these XPC services, we
+        can reduce the logging traffic.
+
+        This is important to do now, since generating the telemetry and reports has
+        a non-zero power cost.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2020-06-04  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

@@ -763 +763 @@
     (home-literal
         "/Library/Preferences/com.apple.Accessibility.plist"
+        "/Library/Preferences/com.apple.AdLib.plist"
         "/Library/Preferences/com.apple.EmojiPreferences.plist"
         "/Library/Preferences/com.apple.InputModePreferences.plist"

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -163 +163 @@
         "hw.cpufamily" ;; <rdar://problem/58416475>
         "hw.cputype"
+        "hw.logicalcpu"
         "hw.machine"
         "hw.memsize"
@@ -647 +648 @@
        (global-name "com.apple.webinspector"))
 
-(allow mach-lookup
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
-    (with report) (with telemetry)
-#endif
-    (global-name "com.apple.awdd")
-    (global-name "com.apple.cookied")
+;; Still actively in use
+(allow mach-lookup
+    (global-name "com.apple.coreservices.launchservicesd")
     (global-name "com.apple.diagnosticd")
     (global-name "com.apple.iconservices")
     (global-name "com.apple.iconservices.store")
+    (global-name "com.apple.powerlog.plxpclogger.xpc")
+    (global-name "com.apple.tccd.system")
+    (global-name "com.apple.trustd.agent")
+)
+
+(allow mach-lookup
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+    (with report) (with telemetry)
+#endif
+    (global-name "com.apple.awdd")
+    (global-name "com.apple.cookied")
     (global-name "com.apple.mobileassetd")
-    (global-name "com.apple.powerlog.plxpclogger.xpc")
 )
 
@@ -686 +694 @@
 #endif
     (global-name "com.apple.PowerManagement.control")
-    (global-name "com.apple.coreservices.launchservicesd")
-    (global-name "com.apple.trustd.agent")
 )
 
@@ -696 +702 @@
 #endif
     (global-name "com.apple.lsd.mapdb")
-)
-
-(allow mach-lookup
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
-    (with telemetry)
-#endif
-    (global-name "com.apple.tccd.system")
 )