Changeset 263259 in webkit

Timestamp:

Jun 19, 2020, 5:27:23 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r253360): [GTK] Page starts loading during animation in back/forward gesture
​https://bugs.webkit.org/show_bug.cgi?id=205650

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-06-19
Reviewed by Carlos Garcia Campos.

r253360 changed the swipe gesture to start loading the page during the gesture, relying on
freezing the layer tree state to prevent unwanted redraws. However, it was implemented for
AC mode, but didn't prevent redraws in non-accelerated mode. Add a simple check to skip
redraws in this case.

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::display): Skip drawing if layer tree state is frozen.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-19  Alexander Mikhaylenko  <alexm@gnome.org>
+
+        REGRESSION(r253360): [GTK] Page starts loading during animation in back/forward gesture
+        https://bugs.webkit.org/show_bug.cgi?id=205650
+
+        Reviewed by Carlos Garcia Campos.
+
+        r253360 changed the swipe gesture to start loading the page during the gesture, relying on
+        freezing the layer tree state to prevent unwanted redraws. However, it was implemented for
+        AC mode, but didn't prevent redraws in non-accelerated mode. Add a simple check to skip
+        redraws in this case.
+
+        * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+        (WebKit::DrawingAreaCoordinatedGraphics::display): Skip drawing if layer tree state is frozen.
+
 2020-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp

@@ -697 +697 @@
     ASSERT(!m_inUpdateBackingStoreState);
 
+    if (m_layerTreeStateIsFrozen)
+        return;
+
     if (m_isPaintingSuspended)
         return;