⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 263265 in webkit


Ignore:
Timestamp:
Jun 19, 2020, 7:35:36 AM (6 years ago)
Author:
svillar@igalia.com
Message:

REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=212897

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/webxr/idlharness.https.window-expected.txt: Updated expectations.

Source/WebCore:

WPT tests were updated in r262254 and they already include the latest changes in the specs. Among others the
XR interface was renamed to XRSystem. We were already using that name in the C++ code but not in the JS interface.
The WPT update brings in another set of changes like the new XRLayer which is already not supported (I am
adding it soon in another patch). Last but not least, the new tests include checks for the XRPermissionStatus interface
which is not going to be implemented soon as it requires the Permission API which is not supported in WebKit yet. All in
all, this patch renames XR to XRSystem and marks as failing the XRLayer (temporarily) and XRPermissionStatus checks.

No new tests as there is no change in functionality.

  • Modules/webxr/WebXRSystem.idl: Rename XR to XRSystem.
  • bindings/js/WebCoreBuiltinNames.h: Ditto.

LayoutTests:

  • platform/wpe/TestExpectations: Re-enable the idlharness.https.window.html test.
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r263262 r263265  
     12020-06-10  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=212897
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * platform/wpe/TestExpectations: Re-enable the idlharness.https.window.html test.
     9
    1102020-06-18  Lauro Moura  <lmoura@igalia.com>
    211

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r263199 r263265  
     12020-06-10  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=212897
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * web-platform-tests/webxr/idlharness.https.window-expected.txt: Updated expectations.
     9
    1102020-06-17  Clark Wang  <clark_wang@apple.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/idlharness.https.window-expected.txt

    r260385 r263265  
    1919PASS Navigator includes NavigatorPlugins: member names are unique
    2020PASS Navigator includes NavigatorConcurrentHardware: member names are unique
    21 PASS XR interface: existence and properties of interface object
    22 PASS XR interface object length
    23 PASS XR interface object name
    24 PASS XR interface: existence and properties of interface prototype object
    25 PASS XR interface: existence and properties of interface prototype object's "constructor" property
    26 PASS XR interface: existence and properties of interface prototype object's @@unscopables property
    27 PASS XR interface: operation isSessionSupported(XRSessionMode)
    28 PASS XR interface: operation requestSession(XRSessionMode, XRSessionInit)
    29 PASS XR interface: attribute ondevicechange
    30 PASS XR must be primary interface of navigator.xr
    31 PASS Stringification of navigator.xr
    32 PASS XR interface: navigator.xr must inherit property "isSessionSupported(XRSessionMode)" with the proper type
    33 PASS XR interface: calling isSessionSupported(XRSessionMode) on navigator.xr with too few arguments must throw TypeError
    34 PASS XR interface: navigator.xr must inherit property "requestSession(XRSessionMode, XRSessionInit)" with the proper type
    35 PASS XR interface: calling requestSession(XRSessionMode, XRSessionInit) on navigator.xr with too few arguments must throw TypeError
    36 PASS XR interface: navigator.xr must inherit property "ondevicechange" with the proper type
     21PASS XRSystem interface: existence and properties of interface object
     22PASS XRSystem interface object length
     23PASS XRSystem interface object name
     24PASS XRSystem interface: existence and properties of interface prototype object
     25PASS XRSystem interface: existence and properties of interface prototype object's "constructor" property
     26PASS XRSystem interface: existence and properties of interface prototype object's @@unscopables property
     27PASS XRSystem interface: operation isSessionSupported(XRSessionMode)
     28PASS XRSystem interface: operation requestSession(XRSessionMode, optional XRSessionInit)
     29PASS XRSystem interface: attribute ondevicechange
    3730PASS XRSession interface: existence and properties of interface object
    3831PASS XRSession interface object length
    … …  
    4437PASS XRSession interface: attribute renderState
    4538PASS XRSession interface: attribute inputSources
    46 PASS XRSession interface: operation updateRenderState(XRRenderStateInit)
     39PASS XRSession interface: operation updateRenderState(optional XRRenderStateInit)
    4740PASS XRSession interface: operation requestReferenceSpace(XRReferenceSpaceType)
    4841PASS XRSession interface: operation requestAnimationFrame(XRFrameRequestCallback)
    … …  
    161154PASS XRInputSourceArray interface: iterable<XRInputSource>
    162155PASS XRInputSourceArray interface: attribute length
    163 PASS XRWebGLLayer interface: existence and properties of interface object
     156FAIL XRLayer interface: existence and properties of interface object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     157FAIL XRLayer interface object length assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     158FAIL XRLayer interface object name assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     159FAIL XRLayer interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     160FAIL XRLayer interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     161FAIL XRLayer interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
     162FAIL XRWebGLLayer interface: existence and properties of interface object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
    164163PASS XRWebGLLayer interface object length
    165164PASS XRWebGLLayer interface object name
    166 PASS XRWebGLLayer interface: existence and properties of interface prototype object
     165FAIL XRWebGLLayer interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRLayer" expected property "XRLayer" missing
    167166PASS XRWebGLLayer interface: existence and properties of interface prototype object's "constructor" property
    168167PASS XRWebGLLayer interface: existence and properties of interface prototype object's @@unscopables property
    … …  
    206205PASS XRReferenceSpaceEvent interface: attribute referenceSpace
    207206PASS XRReferenceSpaceEvent interface: attribute transform
     207FAIL XRPermissionStatus interface: existence and properties of interface object assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     208FAIL XRPermissionStatus interface object length assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     209FAIL XRPermissionStatus interface object name assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     210FAIL XRPermissionStatus interface: existence and properties of interface prototype object assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     211FAIL XRPermissionStatus interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     212FAIL XRPermissionStatus interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
     213FAIL XRPermissionStatus interface: attribute granted assert_own_property: self does not have own property "XRPermissionStatus" expected property "XRPermissionStatus" missing
    208214PASS Navigator interface: attribute xr
    209215PASS Navigator interface: navigator must inherit property "xr" with the proper type

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r263201 r263265  
    922922
    923923# WebXR
    924 webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]
     924webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Pass ]
    925925webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ]
    926926webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]

  • trunk/Source/WebCore/ChangeLog

    r263260 r263265  
     12020-06-10  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=212897
     5
     6        Reviewed by Youenn Fablet.
     7
     8        WPT tests were updated in r262254 and they already include the latest changes in the specs. Among others the
     9        XR interface was renamed to XRSystem. We were already using that name in the C++ code but not in the JS interface.
     10        The WPT update brings in another set of changes like the new XRLayer which is already not supported (I am
     11        adding it soon in another patch). Last but not least, the new tests include checks for the XRPermissionStatus interface
     12        which is not going to be implemented soon as it requires the Permission API which is not supported in WebKit yet. All in
     13        all, this patch renames XR to XRSystem and marks as failing the XRLayer (temporarily) and XRPermissionStatus checks.
     14
     15        No new tests as there is no change in functionality.
     16
     17        * Modules/webxr/WebXRSystem.idl: Rename XR to XRSystem.
     18        * bindings/js/WebCoreBuiltinNames.h: Ditto.
     19
    1202020-06-19  Zalan Bujtas  <zalan@apple.com>
    221

  • trunk/Source/WebCore/Modules/webxr/WebXRSystem.idl

    r261863 r263265  
    3030    SecureContext,
    3131    Exposed=Window,
    32     InterfaceName=XR
     32    InterfaceName=XRSystem
    3333] interface WebXRSystem : EventTarget {
    3434    // Methods

  • trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h

    r263198 r263265  
    246246    macro(WritableStream) \
    247247    macro(XMLHttpRequest) \
    248     macro(XR) \
    249248    macro(XRBoundedReferenceSpace) \
    250249    macro(XRFrame) \
    … …  
    261260    macro(XRSessionEvent) \
    262261    macro(XRSpace) \
     262    macro(XRSystem) \
    263263    macro(XRTest) \
    264264    macro(XRView) \
Note: See TracChangeset for help on using the changeset viewer.