⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 263270 in webkit


Ignore:
Timestamp:
Jun 19, 2020, 9:21:49 AM (6 years ago)
Author:
Chris Dumez
Message:

Move Prefixed WebAudio interfaces behind their own feature flag
​https://bugs.webkit.org/show_bug.cgi?id=213356

Reviewed by Darin Adler.

Source/WebCore:

Move Prefixed WebAudio interfaces behind their own feature flag, on by default. This will
allow us to easily disable the prefixed API and will also allow it to live independently
from the unprefixed API.

  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/WebKitAudioContext.idl:
  • Modules/webaudio/WebKitAudioPannerNode.idl:
  • Modules/webaudio/WebKitOfflineAudioContext.idl:
  • bindings/js/WebCoreBuiltinNames.h:
  • page/Settings.yaml:

Source/WebKit:

  • Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Location:
trunk/Source
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r263268 r263270  
     12020-06-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Move Prefixed WebAudio interfaces behind their own feature flag
     4        https://bugs.webkit.org/show_bug.cgi?id=213356
     5
     6        Reviewed by Darin Adler.
     7
     8        Move Prefixed WebAudio interfaces behind their own feature flag, on by default. This will
     9        allow us to easily disable the prefixed API and will also allow it to live independently
     10        from the unprefixed API.
     11
     12        * Modules/webaudio/AudioContext.idl:
     13        * Modules/webaudio/WebKitAudioContext.idl:
     14        * Modules/webaudio/WebKitAudioPannerNode.idl:
     15        * Modules/webaudio/WebKitOfflineAudioContext.idl:
     16        * bindings/js/WebCoreBuiltinNames.h:
     17        * page/Settings.yaml:
     18
    1192020-06-19  Zalan Bujtas  <zalan@apple.com>
    220

  • trunk/Source/WebCore/Modules/webaudio/AudioContext.idl

    r263198 r263270  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_AUDIO,
    29     EnabledBySetting=ModernUnprefixedWebAudio,
     29    EnabledBySetting=WebAudio&ModernUnprefixedWebAudio,
    3030    ExportMacro=WEBCORE_EXPORT,
    3131] interface AudioContext : EventTarget {

  • trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl

    r263198 r263270  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_AUDIO,
    29     EnabledBySetting=WebAudio,
     29    EnabledBySetting=WebAudio&PrefixedWebAudio,
    3030    ExportMacro=WEBCORE_EXPORT,
    3131    InterfaceName=webkitAudioContext,

  • trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.idl

    r263198 r263270  
    2525[
    2626    Conditional=WEB_AUDIO,
     27    EnabledBySetting=PrefixedWebAudio,
    2728    JSGenerateToJSObject,
    2829    InterfaceName=webkitAudioPannerNode,

  • trunk/Source/WebCore/Modules/webaudio/WebKitOfflineAudioContext.idl

    r263198 r263270  
    2525[
    2626    Conditional=WEB_AUDIO,
     27    EnabledBySetting=PrefixedWebAudio,
    2728    InterfaceName=webkitOfflineAudioContext,
    2829    JSGenerateToJSObject,

  • trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h

    r263265 r263270  
    389389    macro(webkit) \
    390390    macro(webkitAudioContext) \
     391    macro(webkitAudioPannerNode) \
    391392    macro(webkitIDBCursor) \
    392393    macro(webkitIDBDatabase) \
    … …  
    398399    macro(webkitIDBTransaction) \
    399400    macro(webkitIndexedDB) \
     401    macro(webkitOfflineAudioContext) \
    400402    macro(window) \
    401403    macro(writing) \

  • trunk/Source/WebCore/page/Settings.yaml

    r263198 r263270  
    256256webAudioEnabled:
    257257  initial: false
     258prefixedWebAudioEnabled:
     259  initial: false
    258260modernUnprefixedWebAudioEnabled:
    259261  initial: false

  • trunk/Source/WebKit/ChangeLog

    r263269 r263270  
     12020-06-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Move Prefixed WebAudio interfaces behind their own feature flag
     4        https://bugs.webkit.org/show_bug.cgi?id=213356
     5
     6        Reviewed by Darin Adler.
     7
     8        * Shared/WebPreferences.yaml:
     9
    1102020-06-19  Rob Buis  <rbuis@igalia.com>
    211

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r263198 r263270  
    334334  defaultValue: true
    335335  condition: ENABLE(WEB_AUDIO)
     336
     337PrefixedWebAudioEnabled:
     338  type: bool
     339  defaultValue: true
     340  condition: ENABLE(WEB_AUDIO)
     341  humanReadableName: "Prefixed WebAudio API"
     342  humanReadableDescription: "Prefixed WebAudio API"
     343  category: internal
    336344
    337345ModernUnprefixedWebAudioEnabled:

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r263060 r263270  
     12020-06-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Move Prefixed WebAudio interfaces behind their own feature flag
     4        https://bugs.webkit.org/show_bug.cgi?id=213356
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebView/WebView.mm:
     9        (-[WebView _preferencesChanged:]):
     10
    1112020-06-15  Alex Christensen  <achristensen@webkit.org>
    212

  • trunk/Source/WebKitLegacy/mac/WebView/WebView.mm

    r263198 r263270  
    32683268#if ENABLE(WEB_AUDIO)
    32693269    settings.setWebAudioEnabled([preferences webAudioEnabled]);
     3270    settings.setPrefixedWebAudioEnabled([preferences webAudioEnabled]);
    32703271    settings.setModernUnprefixedWebAudioEnabled([preferences modernUnprefixedWebAudioEnabled]);
    32713272#endif

  • trunk/Source/WebKitLegacy/win/ChangeLog

    r262913 r263270  
     12020-06-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Move Prefixed WebAudio interfaces behind their own feature flag
     4        https://bugs.webkit.org/show_bug.cgi?id=213356
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebView.cpp:
     9        (WebView::notifyPreferencesChanged):
     10
    1112020-06-11  David Kilzer  <ddkilzer@apple.com>
    212

  • trunk/Source/WebKitLegacy/win/WebView.cpp

    r263198 r263270  
    55575557#if ENABLE(WEB_AUDIO)
    55585558    settings.setWebAudioEnabled(true);
     5559    settings.setPrefixedWebAudioEnabled(true);
    55595560
    55605561    hr = prefsPrivate->modernUnprefixedWebAudioEnabled(&enabled);
Note: See TracChangeset for help on using the changeset viewer.