Changeset 263271 in webkit

Timestamp:

Jun 19, 2020, 9:30:08 AM (6 years ago)

Author:

Chris Dumez

Message:

Web Inspector: RemoteInspector::singleton() slows down MobileSafari launch
​https://bugs.webkit.org/show_bug.cgi?id=213381
<rdar://problem/64533003>

Reviewed by Darin Adler.

RemoteInspector::singleton() is expensive according to traces. It was called in WebProcessPool::initializeNewWebProcess()
which happens on MobileSafari launch because we prewarm a WebProcess. However, there is no reason to initialize remote
Web Inspector at this point. Per associated comment, Remote Web Inspector needs to be initialized once there is a
sub process hosting one of our Web View. As a result, I moved the initialization call to WebPageProxy::initializeWebPage()
which is when we actually send the IPC to the WebProcess to create the WebPage that is backing the UI-side WebView.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)
• UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-19  Chris Dumez  <cdumez@apple.com>
+
+        Web Inspector: RemoteInspector::singleton() slows down MobileSafari launch
+        https://bugs.webkit.org/show_bug.cgi?id=213381
+        <rdar://problem/64533003>
+
+        Reviewed by Darin Adler.
+
+        RemoteInspector::singleton() is expensive according to traces. It was called in WebProcessPool::initializeNewWebProcess()
+        which happens on MobileSafari launch because we prewarm a WebProcess. However, there is no reason to initialize remote
+        Web Inspector at this point. Per associated comment, Remote Web Inspector needs to be initialized once there is a
+        sub process hosting one of our Web View. As a result, I moved the initialization call to WebPageProxy::initializeWebPage()
+        which is when we actually send the IPC to the WebProcess to create the WebPage that is backing the UI-side WebView.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::initializeWebPage):
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::initializeNewWebProcess):
+
 2020-06-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1060 +1060 @@
     ASSERT(m_drawingArea);
 
+#if ENABLE(REMOTE_INSPECTOR)
+    // Initialize remote inspector connection now that we have a sub-process that is hosting one of our web views.
+    Inspector::RemoteInspector::singleton();
+#endif
+
     send(Messages::WebProcess::CreateWebPage(m_webPageID, creationParameters(m_process, *m_drawingArea)), 0);
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -1116 +1116 @@
 #endif
 
-#if ENABLE(REMOTE_INSPECTOR)
-    // Initialize remote inspector connection now that we have a sub-process that is hosting one of our web views.
-    Inspector::RemoteInspector::singleton();
-#endif
-
 #if PLATFORM(MAC)
     registerDisplayConfigurationCallback();