Changeset 263272 in webkit

Timestamp:

Jun 19, 2020, 9:34:18 AM (6 years ago)

Author:

youenn@apple.com

Message:

LibWebRTCSocketClient::sendTo is too verbose in case of error
​https://bugs.webkit.org/show_bug.cgi?id=213380

Reviewed by Eric Carlson.

Only log error message if the error code is different from the previous one.

• NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:

(WebKit::LibWebRTCSocketClient::sendTo):

• NetworkProcess/webrtc/LibWebRTCSocketClient.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/webrtc/LibWebRTCSocketClient.cpp (modified) (1 diff)
• NetworkProcess/webrtc/LibWebRTCSocketClient.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-19  Youenn Fablet  <youenn@apple.com>
+
+        LibWebRTCSocketClient::sendTo is too verbose in case of error
+        https://bugs.webkit.org/show_bug.cgi?id=213380
+
+        Reviewed by Eric Carlson.
+
+        Only log error message if the error code is different from the previous one.
+
+        * NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
+        (WebKit::LibWebRTCSocketClient::sendTo):
+        * NetworkProcess/webrtc/LibWebRTCSocketClient.h:
+
 2020-06-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp

@@ -73 +73 @@
 {
     auto result = m_socket->SendTo(reinterpret_cast<const uint8_t*>(buffer.data()), buffer.size(), socketAddress, options);
-    UNUSED_PARAM(result);
-    RELEASE_LOG_ERROR_IF(result, Network, "LibWebRTCSocketClient::sendTo failed with error %d", m_socket->GetError());
+    RELEASE_LOG_ERROR_IF(result && m_sendError != result, Network, "LibWebRTCSocketClient::sendTo failed with error %d", m_socket->GetError());
+    m_sendError = result;
 }
 

trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h

@@ -65 +65 @@
     NetworkRTCProvider& m_rtcProvider;
     std::unique_ptr<rtc::AsyncPacketSocket> m_socket;
+    int m_sendError { 0 };
 };