Changeset 263275 in webkit

Timestamp:

Jun 19, 2020, 10:11:27 AM (6 years ago)

Author:

Chris Fleizach

Message:

AX: Make isolated tree enablement status dependent on client preference
​https://bugs.webkit.org/show_bug.cgi?id=213355
<rdar://problem/64506577>

Reviewed by Zalan Bujtas.

Source/WebKit:

We don't want the isolated tree mode in all clients (like Mail or Dictionary).
As a result, we can set this setting to off and allow safari and mini browser turn on more directly.

• Shared/WebPreferences.yaml:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setAccessibilityIsolatedTreeEnabled:]):
(-[WKPreferences _accessibilityIsolatedTreeEnabled]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setAccessibilityIsolatedTreeEnabled):

• WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

• MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate defaultConfiguration]):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/WebPreferences.yaml (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (modified) (1 diff)
• Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp (modified) (2 diffs)
• Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/MiniBrowser/mac/AppDelegate.m (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Make isolated tree enablement status dependent on client preference
+        https://bugs.webkit.org/show_bug.cgi?id=213355
+        <rdar://problem/64506577>
+
+        Reviewed by Zalan Bujtas.
+
+        We don't want the isolated tree mode in all clients (like Mail or Dictionary).
+        As a result, we can set this setting to off and allow safari and mini browser turn on more directly.
+
+        * Shared/WebPreferences.yaml:
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences _setAccessibilityIsolatedTreeEnabled:]):
+        (-[WKPreferences _accessibilityIsolatedTreeEnabled]):
+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+        (WebKit::InjectedBundle::setAccessibilityIsolatedTreeEnabled):
+        * WebProcess/InjectedBundle/InjectedBundle.h:
+
 2020-06-19  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -2014 +2014 @@
 IsAccessibilityIsolatedTreeEnabled:
     type: bool
-    defaultValue: true
+    defaultValue: false
     humanReadableName: "Isolated Accessibility Tree Mode"
     humanReadableDescription: "Enable an accessibility hierarchy for VoiceOver that can be accessed on a secondary thread for improved performance"

trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

@@ -1457 +1457 @@
 }
 
+- (void)_setAccessibilityIsolatedTreeEnabled:(BOOL)accessibilityIsolatedTreeEnabled
+{
+#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+    _preferences->setIsAccessibilityIsolatedTreeEnabled(accessibilityIsolatedTreeEnabled);
+#endif
+}
+
+- (BOOL)_accessibilityIsolatedTreeEnabled
+{
+#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+    return _preferences->isAccessibilityIsolatedTreeEnabled();
+#else
+    return false;
+#endif
+}
+
 @end
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h

@@ -164 +164 @@
 @property (nonatomic, readonly) BOOL _isITPDatabaseEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setServiceWorkerEntitlementDisabledForTesting:) BOOL _serviceWorkerEntitlementDisabledForTesting WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+@property (nonatomic, setter=_setAccessibilityIsolatedTreeEnabled:) BOOL _accessibilityIsolatedTreeEnabled WK_API_AVAILABLE(macos(10.16));
 
 #if !TARGET_OS_IPHONE

trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp

@@ -293 +293 @@
 #endif
 
+#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+    if (preference == "IsAccessibilityIsolatedTreeEnabled")
+        RuntimeEnabledFeatures::sharedFeatures().setIsAccessibilityIsolatedTreeEnabled(enabled);
+#endif
+
     // Map the names used in LayoutTests with the names used in WebCore::Settings and WebPreferencesStore.
 #define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
@@ -615 +620 @@
 }
 
+void InjectedBundle::setAccessibilityIsolatedTreeEnabled(bool enabled)
+{
+#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+    RuntimeEnabledFeatures::sharedFeatures().setIsAccessibilityIsolatedTreeEnabled(enabled);
+#endif
+}
+
 } // namespace WebKit

trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h

@@ -145 +145 @@
     void setWebAnimationsEnabled(bool);
     void setWebAnimationsCSSIntegrationEnabled(bool);
+    void setAccessibilityIsolatedTreeEnabled(bool);
     void dispatchPendingLoadRequests();
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-06-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Make isolated tree enablement status dependent on client preference
+        https://bugs.webkit.org/show_bug.cgi?id=213355
+        <rdar://problem/64506577>
+
+        Reviewed by Zalan Bujtas.
+
+        * MiniBrowser/mac/AppDelegate.m:
+        (-[BrowserAppDelegate defaultConfiguration]):
+
 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/MiniBrowser/mac/AppDelegate.m

@@ -145 +145 @@
         configuration.preferences._mediaDevicesEnabled = YES;
         configuration.preferences._mockCaptureDevicesEnabled = YES;
+        configuration.preferences._accessibilityIsolatedTreeEnabled = YES;
     }