Changeset 263277 in webkit

Timestamp:

Jun 19, 2020, 11:07:16 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

functionCpuClflush checks that the second argument is Int32 but it actually expects it to be UInt32
​https://bugs.webkit.org/show_bug.cgi?id=213388

Patch by Tuomas Karkkainen <​tuomas.webkit@apple.com> on 2020-06-19
Reviewed by Saam Barati.

This changes the check from isInt32() to isUInt32() so that the logic is consistent.

• tools/JSDollarVM.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tools/JSDollarVM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-06-19  Tuomas Karkkainen  <tuomas.webkit@apple.com>
+
+        functionCpuClflush checks that the second argument is Int32 but it actually expects it to be UInt32
+        https://bugs.webkit.org/show_bug.cgi?id=213388
+
+        Reviewed by Saam Barati.
+
+        This changes the check from isInt32() to isUInt32() so that the logic is consistent.
+
+        * tools/JSDollarVM.cpp:
+
 2020-06-18  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

@@ -1743 +1743 @@
     VM& vm = globalObject->vm();
 
-    if (!callFrame->argument(1).isInt32())
+    if (!callFrame->argument(1).isUInt32())
         return JSValue::encode(jsBoolean(false));