Changeset 263295 in webkit

Timestamp:

Jun 19, 2020, 4:37:55 PM (6 years ago)

Author:

pvollan@apple.com

Message:

[macOS] Connections to the preference daemon are established before entering the sandbox
​https://bugs.webkit.org/show_bug.cgi?id=213379

Reviewed by Darin Adler.

Source/WebCore/PAL:

Use correct parameter types in _CFPrefsSetDirectModeEnabled and _CFPrefsSetReadOnly, and move
_CFPrefsSetDirectModeEnabled inside an Objective-C guard, since BOOL only seems to be a builtin
type in Objective-C.

• pal/spi/cf/CFUtilitiesSPI.h:

Source/WebKit:

On macOS, connections to the preference daemon are established before entering the sandbox. These connections also persist
after entering the sandbox and denying access to the preference daemon. There should not be attempts to connect to the
preference daemon before entering the sandbox, since these attempts will not be stopped by the sandbox. This patch moves
code that connects to the preference daemon to be executed after the sandbox has been entered. That includes code to
prevent connections to the Dock and code to initialize WebKit logging. Also, instead of calling [NSBundle bundleForClass:],
call [NSBundle bundleWithIdentifier:], since calling [NSBundle bundleForClass:] will connect to the preference daemon.
Finally, allow the syscall SYS_gethostuuid, since that is needed by CoreFoundation when there is no access to the
preference daemon.

No new tests. This should be covered by existing tests. It would be nice to have a test to make sure that there are no
connections to the preference daemon just before entering the sandbox, but I am not aware of how to implement this.

• NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::initializeSandbox):

• Shared/AuxiliaryProcess.cpp:

(WebKit::AuxiliaryProcess::initialize):

• Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::runInitializationCode):

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::webKit2Bundle):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeSandbox):

• WebProcess/com.apple.WebProcess.sb.in:

Location:

trunk/Source

Files:

• WebCore/PAL/ChangeLog (modified) (1 diff)
• WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/NetworkProcess/mac/NetworkProcessMac.mm (modified) (1 diff)
• WebKit/Shared/AuxiliaryProcess.cpp (modified) (2 diffs)
• WebKit/Shared/Cocoa/WebKit2InitializeCocoa.mm (modified) (2 diffs)
• WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm (modified) (2 diffs)
• WebKit/Shared/mac/AuxiliaryProcessMac.mm (modified) (1 diff)
• WebKit/WebProcess/cocoa/WebProcessCocoa.mm (modified) (4 diffs)
• WebKit/WebProcess/com.apple.WebProcess.sb.in (modified) (1 diff)

trunk/Source/WebCore/PAL/ChangeLog

@@ +1 @@
+2020-06-19  Per Arne Vollan  <pvollan@apple.com>
+
+        [macOS] Connections to the preference daemon are established before entering the sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=213379
+
+        Reviewed by Darin Adler.
+
+        Use correct parameter types in _CFPrefsSetDirectModeEnabled and _CFPrefsSetReadOnly, and move
+        _CFPrefsSetDirectModeEnabled inside an Objective-C guard, since BOOL only seems to be a builtin
+        type in Objective-C.
+
+        * pal/spi/cf/CFUtilitiesSPI.h:
+
 2020-06-19  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h

@@ -59 +59 @@
 void __CFRunLoopSetOptionsReason(__CFRunLoopOptions opts, CFStringRef reason);
 
-void _CFPrefsSetDirectModeEnabled(bool enabled);
-void _CFPrefsSetReadOnly(bool flag);
+#ifdef __OBJC__
+void _CFPrefsSetDirectModeEnabled(BOOL enabled);
+#endif
+void _CFPrefsSetReadOnly(Boolean flag);
 
 WTF_EXTERN_C_END

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-19  Per Arne Vollan  <pvollan@apple.com>
+
+        [macOS] Connections to the preference daemon are established before entering the sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=213379
+
+        Reviewed by Darin Adler.
+
+        On macOS, connections to the preference daemon are established before entering the sandbox. These connections also persist
+        after entering the sandbox and denying access to the preference daemon. There should not be attempts to connect to the
+        preference daemon before entering the sandbox, since these attempts will not be stopped by the sandbox. This patch moves
+        code that connects to the preference daemon to be executed after the sandbox has been entered. That includes code to
+        prevent connections to the Dock and code to initialize WebKit logging. Also, instead of calling [NSBundle bundleForClass:],
+        call [NSBundle bundleWithIdentifier:], since calling [NSBundle bundleForClass:] will connect to the preference daemon.
+        Finally, allow the syscall SYS_gethostuuid, since that is needed by CoreFoundation when there is no access to the
+        preference daemon.
+
+        No new tests. This should be covered by existing tests. It would be nice to have a test to make sure that there are no
+        connections to the preference daemon just before entering the sandbox, but I am not aware of how to implement this.
+
+        * NetworkProcess/mac/NetworkProcessMac.mm:
+        (WebKit::NetworkProcess::initializeSandbox):
+        * Shared/AuxiliaryProcess.cpp:
+        (WebKit::AuxiliaryProcess::initialize):
+        * Shared/Cocoa/WebKit2InitializeCocoa.mm:
+        (WebKit::runInitializationCode):
+        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
+        (WebKit::XPCServiceMain):
+        * Shared/mac/AuxiliaryProcessMac.mm:
+        (WebKit::webKit2Bundle):
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+        (WebKit::WebProcess::initializeSandbox):
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2020-06-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm

@@ -88 +88 @@
 {
     // Need to overide the default, because service has a different bundle ID.
-    NSBundle *webKit2Bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];
+    auto webKitBundle = [NSBundle bundleWithIdentifier:@"com.apple.WebKit"];
 
-    sandboxParameters.setOverrideSandboxProfilePath([webKit2Bundle pathForResource:@"com.apple.WebKit.NetworkProcess" ofType:@"sb"]);
+    sandboxParameters.setOverrideSandboxProfilePath(makeString(String([webKitBundle resourcePath]), "/com.apple.WebKit.NetworkProcess.sb"));
 
     AuxiliaryProcess::initializeSandbox(parameters, sandboxParameters);

trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp

@@ -28 +28 @@
 
 #include "ContentWorldShared.h"
+#include "LogInitialization.h"
 #include "Logging.h"
 #include "SandboxInitializationParameters.h"
+#include <WebCore/LogInitialization.h>
 #include <pal/SessionID.h>
 
@@ -76 +78 @@
     SandboxInitializationParameters sandboxParameters;
     initializeSandbox(parameters, sandboxParameters);
+
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
+    WebCore::initializeLogChannelsIfNecessary();
+    WebKit::initializeLogChannelsIfNecessary();
+#endif // !LOG_DISABLED || !RELEASE_LOG_DISABLED
 
     initializeProcessName(parameters);

trunk/Source/WebKit/Shared/Cocoa/WebKit2InitializeCocoa.mm

@@ -27 +27 @@
 #import "WebKit2Initialize.h"
 
-#import "LogInitialization.h"
 #import "VersionChecks.h"
 #import <JavaScriptCore/InitializeThreading.h>
-#import <WebCore/LogInitialization.h>
 #import <mutex>
 #import <wtf/MainThread.h>
@@ -57 +55 @@
 
     WTF::RefCountedBase::enableThreadingChecksGlobally();
-
-#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
-    WebCore::initializeLogChannelsIfNecessary();
-    WebKit::initializeLogChannelsIfNecessary();
-#endif // !LOG_DISABLED || !RELEASE_LOG_DISABLED
 }
 

trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm

@@ -33 +33 @@
 #import <wtf/RetainPtr.h>
 #import <wtf/spi/darwin/XPCSPI.h>
-
-#if PLATFORM(MAC)
-#import <pal/spi/mac/NSApplicationSPI.h>
-#endif
 
 namespace WebKit {
@@ -170 +166 @@
     // Don't allow Apple Events in WebKit processes. This can be removed when <rdar://problem/14012823> is fixed.
     setenv("__APPLEEVENTSSERVICENAME", "", 1);
-
-    // We don't need to talk to the dock.
-    if (Class nsApplicationClass = NSClassFromString(@"NSApplication")) {
-        if ([nsApplicationClass respondsToSelector:@selector(_preventDockConnections)])
-            [nsApplicationClass _preventDockConnections];
-    }
 #endif
 

trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

@@ -521 +521 @@
 static inline const NSBundle *webKit2Bundle()
 {
-    const static NSBundle *bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];
+    const static NSBundle *bundle = [NSBundle bundleWithIdentifier:@"com.apple.WebKit"];
     return bundle;
 }

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -186 +186 @@
     }
 
-#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
-    WebCore::initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels);
-    WebKit::initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels);
-#endif
-
     WebCore::setApplicationBundleIdentifier(parameters.uiProcessBundleIdentifier);
     setApplicationSDKVersion(parameters.uiProcessSDKVersion);
@@ -232 +227 @@
 
 #if USE(APPKIT)
+    // We don't need to talk to the Dock.
+    [NSApplication _preventDockConnections];
+
     [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }];
 
@@ -239 +237 @@
     method_setImplementation(methodToPatch, (IMP)NSApplicationAccessibilityFocusedUIElement);
 #endif
-    
+
 #if PLATFORM(MAC) && ENABLE(WEBPROCESS_NSRUNLOOP)
     // Need to initialize accessibility for VoiceOver to work when the WebContent process is using NSRunLoop.
@@ -583 +581 @@
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
     // Need to override the default, because service has a different bundle ID.
-    NSBundle *webKit2Bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];
-
-    sandboxParameters.setOverrideSandboxProfilePath([webKit2Bundle pathForResource:@"com.apple.WebProcess" ofType:@"sb"]);
+    auto webKitBundle = [NSBundle bundleWithIdentifier:@"com.apple.WebKit"];
+
+    sandboxParameters.setOverrideSandboxProfilePath(makeString(String([webKitBundle resourcePath]), "/com.apple.WebProcess.sb"));
 
     AuxiliaryProcess::initializeSandbox(parameters, sandboxParameters);

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -1101 +1101 @@
 #endif
         (syscall-number SYS_fstat64_extended) ;; <rdar://problem/61310019>
+        (syscall-number SYS_gethostuuid)
     )