⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 263824 in webkit


Ignore:
Timestamp:
Jul 1, 2020, 4:50:37 PM (6 years ago)
Author:
keith_miller@apple.com
Message:

Rename zeroExtend32ToPtr to zeroExtend32ToWord
https://bugs.webkit.org/show_bug.cgi?id=213866

Reviewed by Saam Barati.

The old name no longer makes sense now that we have configurations
where sizeof(void*) != sizeof(CPURegister).

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM64::zeroExtend32ToWord):
(JSC::MacroAssemblerARM64::branchMul32):
(JSC::MacroAssemblerARM64::zeroExtend32ToPtr): Deleted.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::zeroExtend32ToWord):
(JSC::MacroAssemblerARMv7::zeroExtend32ToPtr): Deleted.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::zeroExtend32ToWord):
(JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): Deleted.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::mul32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::zeroExtend32ToWord):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): Deleted.

  • b3/air/AirOpcode.opcodes:
  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStringSlice):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
(JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithSize):
(JSC::DFG::SpeculativeJIT::emitAllocateButterfly):
(JSC::DFG::SpeculativeJIT::compileWeakMapGet):
(JSC::DFG::SpeculativeJIT::emitInitializeButterfly):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::reboxAccordingToFormat):

  • jit/CallFrameShuffler64.cpp:

(JSC::CallFrameShuffler::emitBox):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitLoadInt32):

  • wasm/js/JSToWasm.cpp:

(JSC::Wasm::boxWasmResult):

  • wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

  • yarr/YarrJIT.cpp:
Location:
trunk/Source/JavaScriptCore
Files:
21 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r263810 r263824  
     12020-07-01  Keith Miller  <keith_miller@apple.com>
     2
     3        Rename zeroExtend32ToPtr to zeroExtend32ToWord
     4        https://bugs.webkit.org/show_bug.cgi?id=213866
     5
     6        Reviewed by Saam Barati.
     7
     8        The old name no longer makes sense now that we have configurations
     9        where sizeof(void*) != sizeof(CPURegister).
     10
     11        * assembler/MacroAssemblerARM64.h:
     12        (JSC::MacroAssemblerARM64::branchTruncateDoubleToInt32):
     13        (JSC::MacroAssemblerARM64::zeroExtend32ToWord):
     14        (JSC::MacroAssemblerARM64::branchMul32):
     15        (JSC::MacroAssemblerARM64::zeroExtend32ToPtr): Deleted.
     16        * assembler/MacroAssemblerARMv7.h:
     17        (JSC::MacroAssemblerARMv7::zeroExtend32ToWord):
     18        (JSC::MacroAssemblerARMv7::zeroExtend32ToPtr): Deleted.
     19        * assembler/MacroAssemblerMIPS.h:
     20        (JSC::MacroAssemblerMIPS::zeroExtend32ToWord):
     21        (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): Deleted.
     22        * assembler/MacroAssemblerX86Common.h:
     23        (JSC::MacroAssemblerX86Common::add32):
     24        (JSC::MacroAssemblerX86Common::and32):
     25        (JSC::MacroAssemblerX86Common::mul32):
     26        (JSC::MacroAssemblerX86Common::or32):
     27        (JSC::MacroAssemblerX86Common::xor32):
     28        (JSC::MacroAssemblerX86Common::zeroExtend32ToWord):
     29        (JSC::MacroAssemblerX86Common::branchAdd32):
     30        (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): Deleted.
     31        * b3/air/AirOpcode.opcodes:
     32        * bytecode/AccessCase.cpp:
     33        (JSC::AccessCase::generateWithGuard):
     34        * dfg/DFGOSRExit.cpp:
     35        (JSC::DFG::OSRExit::compileExit):
     36        * dfg/DFGSpeculativeJIT.cpp:
     37        (JSC::DFG::SpeculativeJIT::compileStringSlice):
     38        (JSC::DFG::SpeculativeJIT::compileValueToInt32):
     39        (JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
     40        (JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult):
     41        (JSC::DFG::SpeculativeJIT::compileArithDiv):
     42        (JSC::DFG::SpeculativeJIT::compileCreateRest):
     43        (JSC::DFG::SpeculativeJIT::compileArraySlice):
     44        (JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
     45        (JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithSize):
     46        (JSC::DFG::SpeculativeJIT::emitAllocateButterfly):
     47        (JSC::DFG::SpeculativeJIT::compileWeakMapGet):
     48        (JSC::DFG::SpeculativeJIT::emitInitializeButterfly):
     49        * dfg/DFGSpeculativeJIT64.cpp:
     50        (JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
     51        (JSC::DFG::SpeculativeJIT::compile):
     52        * ftl/FTLOSRExitCompiler.cpp:
     53        (JSC::FTL::reboxAccordingToFormat):
     54        * jit/CallFrameShuffler64.cpp:
     55        (JSC::CallFrameShuffler::emitBox):
     56        * jit/JITOpcodes.cpp:
     57        (JSC::JIT::emit_op_has_indexed_property):
     58        * jit/JITOpcodes32_64.cpp:
     59        (JSC::JIT::emit_op_has_indexed_property):
     60        * jit/JITPropertyAccess.cpp:
     61        (JSC::JIT::emit_op_put_by_val):
     62        * jit/JSInterfaceJIT.h:
     63        (JSC::JSInterfaceJIT::emitLoadInt32):
     64        * wasm/js/JSToWasm.cpp:
     65        (JSC::Wasm::boxWasmResult):
     66        * wasm/js/WasmToJS.cpp:
     67        (JSC::Wasm::wasmToJS):
     68        * wasm/js/WebAssemblyFunction.cpp:
     69        (JSC::WebAssemblyFunction::jsCallEntrypointSlow):
     70        * yarr/YarrJIT.cpp:
     71
    1722020-07-01  Saam Barati  <sbarati@apple.com>
    273
  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM64.h

    r263380 r263824  
    19001900        // Truncate to a 64-bit integer in dataTempRegister, copy the low 32-bit to dest.
    19011901        m_assembler.fcvtzs<64, 64>(getCachedDataTempRegisterIDAndInvalidate(), src);
    1902         zeroExtend32ToPtr(dataTempRegister, dest);
     1902        zeroExtend32ToWord(dataTempRegister, dest);
    19031903        // Check the low 32-bits sign extend to be equal to the full value.
    19041904        m_assembler.cmp<64>(dataTempRegister, dataTempRegister, Assembler::SXTW, 0);
     
    25162516    }
    25172517
    2518     void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
     2518    void zeroExtend32ToWord(RegisterID src, RegisterID dest)
    25192519    {
    25202520        m_assembler.uxtw(dest, src);
     
    31963196        m_assembler.asr<32>(scratch2, dest, 31);
    31973197        // After a mul32 the top 32 bits of the register should be clear.
    3198         zeroExtend32ToPtr(dest, dest);
     3198        zeroExtend32ToWord(dest, dest);
    31993199        // Check that bits 31..63 of the original result were all equal.
    32003200        return branch32(NotEqual, scratch2, scratch1);
  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

    r263380 r263824  
    14261426    }
    14271427
    1428     void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
     1428    void zeroExtend32ToWord(RegisterID src, RegisterID dest)
    14291429    {
    14301430        move(src, dest);
  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h

    r263049 r263824  
    16931693    }
    16941694
    1695     void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
     1695    void zeroExtend32ToWord(RegisterID src, RegisterID dest)
    16961696    {
    16971697        if (src != dest || m_fixedWidth)
  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h

    r258063 r263824  
    209209    {
    210210        if (!imm.m_value) {
    211             zeroExtend32ToPtr(src, dest);
     211            zeroExtend32ToWord(src, dest);
    212212            return;
    213213        }
     
    334334    {
    335335        if (op1 == op2)
    336             zeroExtend32ToPtr(op1, dest);
     336            zeroExtend32ToWord(op1, dest);
    337337        else if (op1 == dest)
    338338            and32(op2, dest);
     
    351351            and32(op2, dest);
    352352        } else {
    353             zeroExtend32ToPtr(op2, dest);
     353            zeroExtend32ToWord(op2, dest);
    354354            and32(op1, dest);
    355355        }
     
    495495            mul32(op2, dest);
    496496        } else {
    497             zeroExtend32ToPtr(op2, dest);
     497            zeroExtend32ToWord(op2, dest);
    498498            mul32(op1, dest);
    499499        }
     
    670670    {
    671671        if (op1 == op2)
    672             zeroExtend32ToPtr(op1, dest);
     672            zeroExtend32ToWord(op1, dest);
    673673        else if (op1 == dest)
    674674            or32(op2, dest);
     
    687687            or32(op2, dest);
    688688        } else {
    689             zeroExtend32ToPtr(op2, dest);
     689            zeroExtend32ToWord(op2, dest);
    690690            or32(op1, dest);
    691691        }
     
    10301030            xor32(op2, dest);
    10311031        } else {
    1032             zeroExtend32ToPtr(op2, dest);
     1032            zeroExtend32ToWord(op2, dest);
    10331033            xor32(op1, dest);
    10341034        }
     
    22882288    }
    22892289
    2290     void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
     2290    void zeroExtend32ToWord(RegisterID src, RegisterID dest)
    22912291    {
    22922292        m_assembler.movl_rr(src, dest);
    22932293    }
    22942294
    2295     void zeroExtend32ToPtr(TrustedImm32 src, RegisterID dest)
     2295    void zeroExtend32ToWord(TrustedImm32 src, RegisterID dest)
    22962296    {
    22972297        m_assembler.movl_i32r(src.m_value, dest);
     
    23762376    }
    23772377
    2378     void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
     2378    void zeroExtend32ToWord(RegisterID src, RegisterID dest)
    23792379    {
    23802380        move(src, dest);
     
    28232823            return branchAdd32(cond, op2, dest);
    28242824        }
    2825         zeroExtend32ToPtr(op2, dest);
     2825        zeroExtend32ToWord(op2, dest);
    28262826        return branchAdd32(cond, op1, dest);
    28272827    }
  • trunk/Source/JavaScriptCore/b3/air/AirOpcode.opcodes

    r247889 r263824  
    643643
    644644Move32 U:G:32, ZD:G:32
    645     Tmp, Tmp as zeroExtend32ToPtr
     645    Tmp, Tmp as zeroExtend32ToWord
    646646    Addr, Tmp as load32
    647647    Index, Tmp as load32
    648648    Tmp, Addr as store32
    649649    Tmp, Index as store32
    650     x86: Imm, Tmp as zeroExtend32ToPtr
     650    x86: Imm, Tmp as zeroExtend32ToWord
    651651    x86: Imm, Addr as store32
    652652    x86: Imm, Index as store32
  • trunk/Source/JavaScriptCore/bytecode/AccessCase.cpp

    r263470 r263824  
    938938        jit.loadPtr(CCallHelpers::Address(baseGPR, ScopedArguments::offsetOfScope()), scratch2GPR);
    939939        jit.loadPtr(CCallHelpers::Address(scratchGPR, ScopedArgumentsTable::offsetOfArguments()), scratchGPR);
    940         jit.zeroExtend32ToPtr(propertyGPR, scratch3GPR);
     940        jit.zeroExtend32ToWord(propertyGPR, scratch3GPR);
    941941        jit.load32(CCallHelpers::BaseIndex(scratchGPR, scratch3GPR, CCallHelpers::TimesFour), scratchGPR);
    942942        failAndIgnore.append(jit.branch32(CCallHelpers::Equal, scratchGPR, CCallHelpers::TrustedImm32(ScopeOffset::invalidOffset)));
     
    983983        state.failAndRepatch.append(jit.branch32(CCallHelpers::AboveOrEqual, propertyGPR, scratchGPR));
    984984        state.failAndRepatch.append(jit.branchTestPtr(CCallHelpers::NonZero, CCallHelpers::Address(baseGPR, DirectArguments::offsetOfMappedArguments())));
    985         jit.zeroExtend32ToPtr(propertyGPR, scratchGPR);
     985        jit.zeroExtend32ToWord(propertyGPR, scratchGPR);
    986986        jit.loadValue(CCallHelpers::BaseIndex(baseGPR, scratchGPR, CCallHelpers::TimesEight, DirectArguments::storageOffset()), valueRegs);
    987987        state.succeed();
     
    11141114        jit.loadPtr(CCallHelpers::Address(scratch2GPR, StringImpl::dataOffset()), scratch2GPR);
    11151115        auto is16Bit = jit.branchTest32(CCallHelpers::Zero, scratchGPR, CCallHelpers::TrustedImm32(StringImpl::flagIs8Bit()));
    1116         jit.zeroExtend32ToPtr(propertyGPR, scratchGPR);
     1116        jit.zeroExtend32ToWord(propertyGPR, scratchGPR);
    11171117        jit.load8(CCallHelpers::BaseIndex(scratch2GPR, scratchGPR, CCallHelpers::TimesOne, 0), scratch2GPR);
    11181118        auto is8BitLoadDone = jit.jump();
    11191119        is16Bit.link(&jit);
    1120         jit.zeroExtend32ToPtr(propertyGPR, scratchGPR);
     1120        jit.zeroExtend32ToWord(propertyGPR, scratchGPR);
    11211121        jit.load16(CCallHelpers::BaseIndex(scratch2GPR, scratchGPR, CCallHelpers::TimesTwo, 0), scratch2GPR);
    11221122        is8BitLoadDone.link(&jit);
     
    11781178            isOutOfBounds = jit.branch32(CCallHelpers::AboveOrEqual, propertyGPR, CCallHelpers::Address(scratchGPR, ArrayStorage::vectorLengthOffset()));
    11791179
    1180             jit.zeroExtend32ToPtr(propertyGPR, scratch2GPR);
     1180            jit.zeroExtend32ToWord(propertyGPR, scratch2GPR);
    11811181#if USE(JSVALUE64)
    11821182            jit.loadValue(CCallHelpers::BaseIndex(scratchGPR, scratch2GPR, CCallHelpers::TimesEight, ArrayStorage::vectorOffset()), JSValueRegs(scratchGPR));
     
    12121212            jit.loadPtr(CCallHelpers::Address(baseGPR, JSObject::butterflyOffset()), scratchGPR);
    12131213            isOutOfBounds = jit.branch32(CCallHelpers::AboveOrEqual, propertyGPR, CCallHelpers::Address(scratchGPR, Butterfly::offsetOfPublicLength()));
    1214             jit.zeroExtend32ToPtr(propertyGPR, scratch2GPR);
     1214            jit.zeroExtend32ToWord(propertyGPR, scratch2GPR);
    12151215            if (m_type == IndexedDoubleLoad) {
    12161216                RELEASE_ASSERT(state.scratchFPR != InvalidFPRReg);
  • trunk/Source/JavaScriptCore/dfg/DFGOSRExit.cpp

    r262570 r263824  
    735735#if USE(JSVALUE64)
    736736            jit.load64(scratch + index, GPRInfo::regT0);
    737             jit.zeroExtend32ToPtr(GPRInfo::regT0, GPRInfo::regT0);
     737            jit.zeroExtend32ToWord(GPRInfo::regT0, GPRInfo::regT0);
    738738            jit.or64(GPRInfo::numberTagRegister, GPRInfo::regT0);
    739739            jit.store64(GPRInfo::regT0, AssemblyHelpers::addressFor(operand));
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

    r263470 r263824  
    17111711
    17121712    // Load the character into scratchReg
    1713     m_jit.zeroExtend32ToPtr(startIndexGPR, startIndexGPR);
     1713    m_jit.zeroExtend32ToWord(startIndexGPR, startIndexGPR);
    17141714    auto is16Bit = m_jit.branchTest32(MacroAssembler::Zero, MacroAssembler::Address(temp2GPR, StringImpl::flagsOffset()), TrustedImm32(StringImpl::flagIs8Bit()));
    17151715
     
    25192519        GPRReg op1GPR = op1.gpr();
    25202520        GPRReg resultGPR = result.gpr();
    2521         m_jit.zeroExtend32ToPtr(op1GPR, resultGPR);
     2521        m_jit.zeroExtend32ToWord(op1GPR, resultGPR);
    25222522        strictInt32Result(resultGPR, node, DataFormatInt32);
    25232523        return;
     
    26042604
    26052605            isInteger.link(&m_jit);
    2606             m_jit.zeroExtend32ToPtr(gpr, resultGpr);
     2606            m_jit.zeroExtend32ToWord(gpr, resultGpr);
    26072607
    26082608            converted.link(&m_jit);
     
    26912691            SpeculateInt32Operand op1(this, node->child1());
    26922692            GPRTemporary result(this, Reuse, op1);
    2693             m_jit.zeroExtend32ToPtr(op1.gpr(), result.gpr());
     2693            m_jit.zeroExtend32ToWord(op1.gpr(), result.gpr());
    26942694            strictInt52Result(result.gpr(), node);
    26952695            return;
     
    31113111    if (node->shouldSpeculateInt52()) {
    31123112        ASSERT(enableInt52());
    3113         m_jit.zeroExtend32ToPtr(resultReg, resultReg);
     3113        m_jit.zeroExtend32ToWord(resultReg, resultReg);
    31143114        strictInt52Result(resultReg, node);
    31153115        return;
     
    55615561            JITCompiler::Jump notNeg2ToThe31 =
    55625562                m_jit.branch32(JITCompiler::NotEqual, op1GPR, TrustedImm32(-2147483647-1));
    5563             m_jit.zeroExtend32ToPtr(op1GPR, eax.gpr());
     5563            m_jit.zeroExtend32ToWord(op1GPR, eax.gpr());
    55645564            done.append(m_jit.jump());
    55655565       
     
    82868286
    82878287        CCallHelpers::Jump skipLoop = m_jit.branch32(MacroAssembler::Equal, arrayLengthGPR, TrustedImm32(0));
    8288         m_jit.zeroExtend32ToPtr(arrayLengthGPR, currentLengthGPR);
     8288        m_jit.zeroExtend32ToWord(arrayLengthGPR, currentLengthGPR);
    82898289        m_jit.addPtr(Imm32(sizeof(Register) * node->numberOfArgumentsToSkip()), argumentsStartGPR);
    82908290
     
    89568956
    89578957    m_jit.loadPtr(MacroAssembler::Address(resultGPR, JSObject::butterflyOffset()), resultButterfly);
    8958     m_jit.zeroExtend32ToPtr(tempGPR, tempGPR);
    8959     m_jit.zeroExtend32ToPtr(loadIndex, loadIndex);
     8958    m_jit.zeroExtend32ToWord(tempGPR, tempGPR);
     8959    m_jit.zeroExtend32ToWord(loadIndex, loadIndex);
    89608960    auto done = m_jit.branchPtr(MacroAssembler::AboveOrEqual, loadIndex, tempGPR);
    89618961
     
    90149014#endif
    90159015
    9016             m_jit.zeroExtend32ToPtr(lengthGPR, lengthGPR);
    9017             m_jit.zeroExtend32ToPtr(indexGPR, indexGPR);
     9016            m_jit.zeroExtend32ToWord(lengthGPR, lengthGPR);
     9017            m_jit.zeroExtend32ToWord(indexGPR, indexGPR);
    90189018
    90199019            auto loop = m_jit.label();
     
    91229122#endif
    91239123
    9124         m_jit.zeroExtend32ToPtr(lengthGPR, lengthGPR);
    9125         m_jit.zeroExtend32ToPtr(indexGPR, indexGPR);
     9124        m_jit.zeroExtend32ToWord(lengthGPR, lengthGPR);
     9125        m_jit.zeroExtend32ToWord(indexGPR, indexGPR);
    91269126
    91279127        auto loop = m_jit.label();
     
    1043510435#if CPU(ARM64E)
    1043610436    // sizeGPR is still boxed as a number and there is no 32-bit variant of the PAC instructions.
    10437     m_jit.zeroExtend32ToPtr(sizeGPR, scratchGPR);
     10437    m_jit.zeroExtend32ToWord(sizeGPR, scratchGPR);
    1043810438    m_jit.tagArrayPtr(scratchGPR, storageGPR);
    1043910439#endif
     
    1247212472    RELEASE_ASSERT(RegisterSet(storageResultGPR, sizeGPR, scratch1, scratch2, scratch3).numberOfSetGPRs() == 5);
    1247312473    ASSERT((1 << 3) == sizeof(JSValue));
    12474     m_jit.zeroExtend32ToPtr(sizeGPR, scratch1);
     12474    m_jit.zeroExtend32ToWord(sizeGPR, scratch1);
    1247512475    m_jit.lshift32(TrustedImm32(3), scratch1);
    1247612476    m_jit.add32(TrustedImm32(sizeof(IndexingHeader)), scratch1, scratch2);
     
    1378813788    if (node->child1().useKind() == WeakSetObjectUse) {
    1378913789        static_assert(sizeof(WeakMapBucket<WeakMapBucketDataKey>) == sizeof(void*), "");
    13790         m_jit.zeroExtend32ToPtr(indexGPR, bucketGPR);
     13790        m_jit.zeroExtend32ToWord(indexGPR, bucketGPR);
    1379113791        m_jit.lshiftPtr(MacroAssembler::Imm32(sizeof(void*) == 4 ? 2 : 3), bucketGPR);
    1379213792        m_jit.addPtr(bufferGPR, bucketGPR);
     
    1379413794        ASSERT(node->child1().useKind() == WeakMapObjectUse);
    1379513795        static_assert(sizeof(WeakMapBucket<WeakMapBucketDataKeyValue>) == 16, "");
    13796         m_jit.zeroExtend32ToPtr(indexGPR, bucketGPR);
     13796        m_jit.zeroExtend32ToWord(indexGPR, bucketGPR);
    1379713797        m_jit.lshiftPtr(MacroAssembler::Imm32(4), bucketGPR);
    1379813798        m_jit.addPtr(bufferGPR, bucketGPR);
     
    1403714037void SpeculativeJIT::emitInitializeButterfly(GPRReg storageGPR, GPRReg sizeGPR, JSValueRegs emptyValueRegs, GPRReg scratchGPR)
    1403814038{
    14039     m_jit.zeroExtend32ToPtr(sizeGPR, scratchGPR);
     14039    m_jit.zeroExtend32ToWord(sizeGPR, scratchGPR);
    1404014040    MacroAssembler::Jump done = m_jit.branchTest32(MacroAssembler::Zero, scratchGPR);
    1404114041    MacroAssembler::Label loop = m_jit.label();
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

    r263134 r263824  
    10241024                result = gpr;
    10251025            }
    1026             m_jit.zeroExtend32ToPtr(gpr, result);
     1026            m_jit.zeroExtend32ToWord(gpr, result);
    10271027            returnFormat = DataFormatInt32;
    10281028            return result;
     
    50885088        DataViewData data = node->dataViewData();
    50895089
    5090         m_jit.zeroExtend32ToPtr(indexGPR, t2);
     5090        m_jit.zeroExtend32ToWord(indexGPR, t2);
    50915091        if (data.byteSize > 1)
    50925092            m_jit.add64(TrustedImm32(data.byteSize - 1), t2);
     
    50985098        cageTypedArrayStorage(dataViewGPR, t2);
    50995099
    5100         m_jit.zeroExtend32ToPtr(indexGPR, t1);
     5100        m_jit.zeroExtend32ToWord(indexGPR, t1);
    51015101        auto baseIndex = JITCompiler::BaseIndex(t2, t1, MacroAssembler::TimesOne);
    51025102
     
    52895289        GPRReg isLittleEndianGPR = isLittleEndianOperand ? isLittleEndianOperand->gpr() : InvalidGPRReg;
    52905290
    5291         m_jit.zeroExtend32ToPtr(indexGPR, t2);
     5291        m_jit.zeroExtend32ToWord(indexGPR, t2);
    52925292        if (data.byteSize > 1)
    52935293            m_jit.add64(TrustedImm32(data.byteSize - 1), t2);
     
    52995299        cageTypedArrayStorage(dataViewGPR, t2);
    53005300
    5301         m_jit.zeroExtend32ToPtr(indexGPR, t1);
     5301        m_jit.zeroExtend32ToWord(indexGPR, t1);
    53025302        auto baseIndex = JITCompiler::BaseIndex(t2, t1, MacroAssembler::TimesOne);
    53035303
     
    54015401
    54025402                auto emitBigEndianCode = [&] {
    5403                     m_jit.zeroExtend32ToPtr(valueGPR, t3);
     5403                    m_jit.zeroExtend32ToWord(valueGPR, t3);
    54045404                    m_jit.byteSwap32(t3);
    54055405                    m_jit.store32(t3, baseIndex);
  • trunk/Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp

    r262570 r263824  
    5353    switch (format) {
    5454    case DataFormatInt32: {
    55         jit.zeroExtend32ToPtr(value, value);
     55        jit.zeroExtend32ToWord(value, value);
    5656        jit.or64(GPRInfo::numberTagRegister, value);
    5757        break;
     
    7474
    7575    case DataFormatBoolean: {
    76         jit.zeroExtend32ToPtr(value, value);
     76        jit.zeroExtend32ToWord(value, value);
    7777        jit.or32(MacroAssembler::TrustedImm32(JSValue::ValueFalse), value);
    7878        break;
  • trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h

    r263470 r263824  
    14811481       
    14821482        isInt32.link(this);
    1483         zeroExtend32ToPtr(source, target);
     1483        zeroExtend32ToWord(source, target);
    14841484        or64(GPRInfo::numberTagRegister, target);
    14851485       
  • trunk/Source/JavaScriptCore/jit/CallFrameShuffler64.cpp

    r261895 r263824  
    8585            if (verbose)
    8686                dataLog("   * Boxing ", cachedRecovery.recovery());
    87             m_jit.zeroExtend32ToPtr(
     87            m_jit.zeroExtend32ToWord(
    8888                cachedRecovery.recovery().gpr(),
    8989                cachedRecovery.recovery().gpr());
  • trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp

    r263470 r263824  
    14371437    // to 64-bits is necessary since it's used in the address calculation. We zero extend rather than sign
    14381438    // extending since it makes it easier to re-tag the value in the slow case.
    1439     zeroExtend32ToPtr(regT1, regT1);
     1439    zeroExtend32ToWord(regT1, regT1);
    14401440
    14411441    emitJumpSlowCaseIfNotJSCell(regT0, base);
  • trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp

    r263049 r263824  
    12161216    // to 64-bits is necessary since it's used in the address calculation. We zero extend rather than sign
    12171217    // extending since it makes it easier to re-tag the value in the slow case.
    1218     zeroExtend32ToPtr(regT1, regT1);
     1218    zeroExtend32ToWord(regT1, regT1);
    12191219
    12201220    emitArrayProfilingSiteWithCell(regT0, regT2, profile);
  • trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp

    r262613 r263824  
    125125        addSlowCase(notIndex);
    126126        // See comment in op_get_by_val.
    127         zeroExtend32ToPtr(regT1, regT1);
     127        zeroExtend32ToWord(regT1, regT1);
    128128    }
    129129    emitArrayProfilingSiteWithCell(regT0, regT2, profile);
  • trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h

    r254947 r263824  
    112112        load64(addressFor(virtualRegister), dst);
    113113        Jump notInt32 = branchIfNotInt32(dst);
    114         zeroExtend32ToPtr(dst, dst);
     114        zeroExtend32ToWord(dst, dst);
    115115        return notInt32;
    116116    }
  • trunk/Source/JavaScriptCore/wasm/js/JSToWasm.cpp

    r262098 r263824  
    5050        break;
    5151    case Wasm::I32:
    52         jit.zeroExtend32ToPtr(src.gpr(), dst.payloadGPR());
     52        jit.zeroExtend32ToWord(src.gpr(), dst.payloadGPR());
    5353        jit.boxInt32(dst.payloadGPR(), dst, DoNotHaveTagRegisters);
    5454        break;
  • trunk/Source/JavaScriptCore/wasm/js/WasmToJS.cpp

    r261755 r263824  
    146146                ++marshalledGPRs;
    147147                if (argType == I32) {
    148                     jit.zeroExtend32ToPtr(gprReg, gprReg); // Clear non-int32 and non-tag bits.
     148                    jit.zeroExtend32ToWord(gprReg, gprReg); // Clear non-int32 and non-tag bits.
    149149                    jit.boxInt32(gprReg, JSValueRegs(gprReg), DoNotHaveTagRegisters);
    150150                }
     
    295295            slowPath.append(jit.branchIfNotNumber(GPRInfo::returnValueGPR, DoNotHaveTagRegisters));
    296296            slowPath.append(jit.branchIfNotInt32(JSValueRegs(GPRInfo::returnValueGPR), DoNotHaveTagRegisters));
    297             jit.zeroExtend32ToPtr(GPRInfo::returnValueGPR, dest);
     297            jit.zeroExtend32ToWord(GPRInfo::returnValueGPR, dest);
    298298            done.append(jit.jump());
    299299
  • trunk/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp

    r262098 r263824  
    263263                jit.store32(scratchGPR, calleeFrame.withOffset(wasmCallInfo.params[i].offsetFromSP()));
    264264            else
    265                 jit.zeroExtend32ToPtr(scratchGPR, wasmCallInfo.params[i].gpr());
     265                jit.zeroExtend32ToWord(scratchGPR, wasmCallInfo.params[i].gpr());
    266266            break;
    267267        }
  • trunk/Source/JavaScriptCore/yarr/YarrJIT.cpp

    r261569 r263824  
    37383738        }
    37393739        // The ABI doesn't guarantee the upper bits are zero on unsigned arguments, so clear them ourselves.
    3740         zeroExtend32ToPtr(index, index);
    3741         zeroExtend32ToPtr(length, length);
     3740        zeroExtend32ToWord(index, index);
     3741        zeroExtend32ToWord(length, length);
    37423742#if OS(WINDOWS)
    37433743        if (compileMode == IncludeSubpatterns)
     
    37563756
    37573757        // The ABI doesn't guarantee the upper bits are zero on unsigned arguments, so clear them ourselves.
    3758         zeroExtend32ToPtr(index, index);
    3759         zeroExtend32ToPtr(length, length);
     3758        zeroExtend32ToWord(index, index);
     3759        zeroExtend32ToWord(length, length);
    37603760#elif CPU(ARM_THUMB2)
    37613761        push(ARMRegisters::r4);
Note: See TracChangeset for help on using the changeset viewer.