Changeset 263845 in webkit

Timestamp:

Jul 2, 2020, 7:52:20 AM (6 years ago)

Author:

Alan Bujtas

Message:

[LFC][IFC] Use <tr> computed height as minimum height for the row
​https://bugs.webkit.org/show_bug.cgi?id=213880

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-fixed-row-height-simple.html

• layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

LayoutTests:

• fast/layoutformattingcontext/table-fixed-row-height-simple-expected.html: Added.
• fast/layoutformattingcontext/table-fixed-row-height-simple.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/layoutformattingcontext/table-fixed-row-height-simple-expected.html (added)
• LayoutTests/fast/layoutformattingcontext/table-fixed-row-height-simple.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/tableformatting/TableLayout.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-02  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Use <tr> computed height as minimum height for the row
+        https://bugs.webkit.org/show_bug.cgi?id=213880
+
+        Reviewed by Antti Koivisto.
+
+        * fast/layoutformattingcontext/table-fixed-row-height-simple-expected.html: Added.
+        * fast/layoutformattingcontext/table-fixed-row-height-simple.html: Added.
+
 2020-07-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-02  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Use <tr> computed height as minimum height for the row
+        https://bugs.webkit.org/show_bug.cgi?id=213880
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/layoutformattingcontext/table-fixed-row-height-simple.html
+
+        * layout/tableformatting/TableLayout.cpp:
+        (WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):
+
 2020-07-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/layout/tableformatting/TableLayout.cpp

@@ -268 +268 @@
         auto maximumColumnAscent = InlineLayoutUnit { };
         auto maximumColumnDescent = InlineLayoutUnit { };
+        // Initial minimum height is the computed height if available <tr style="height: 100px"><td></td></tr>
+        rowHeight[rowIndex] = formattingContext().geometry().computedHeight(rows.list()[rowIndex].box(), availableVerticalSpace).valueOr(0_lu);
         for (size_t columnIndex = 0; columnIndex < columns.size(); ++columnIndex) {
             auto& slot = *m_grid.slot({ columnIndex, rowIndex });