Changeset 263848 in webkit

Timestamp:

Jul 2, 2020, 9:31:46 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r263625): run-minibrowser fails on mac
​https://bugs.webkit.org/show_bug.cgi?id=213876

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-07-02
Reviewed by Darin Adler.

• Scripts/webkitpy/port/base.py:

(Port.run_minibrowser): _run_script() expects a string as first argument. Command-line args
are passed through a keyword.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/base.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-07-02  Philippe Normand  <pnormand@igalia.com>
+
+        REGRESSION(r263625): run-minibrowser fails on mac
+        https://bugs.webkit.org/show_bug.cgi?id=213876
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.run_minibrowser): _run_script() expects a string as first argument. Command-line args
+        are passed through a keyword.
+
 2020-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/base.py

@@ -1370 +1370 @@
     def run_minibrowser(self, args):
         # FIXME: Migrate to webkitpy based run-minibrowser. https://bugs.webkit.org/show_bug.cgi?id=213464
-        return self._run_script(["old-run-minibrowser", ] + args)
+        return self._run_script("old-run-minibrowser", args=args)
 
     @memoized