Changeset 263860 in webkit

Timestamp:

Jul 2, 2020, 2:08:06 PM (6 years ago)

Author:

Simon Fraser

Message:

REGRESSION(r260276): menu items in footer of ​https://salo.ai are invisible until you hover or resize
​https://bugs.webkit.org/show_bug.cgi?id=213712
<rdar://problem/64893190>

Reviewed by Zalan Bujtas.

Source/WebCore:

A negative z-index child triggers a foreground layer inside overflow scroll. This foreground layer
gets the PaintingOverflowContents flag but not the PaintingCompositingScrollingPhase flag, but we still need
to avoid the clip check that happens in RenderBlock::paint(), so change RenderLayer::paintLayerContents()
to just check for isPaintingOverflowContents.

Test: compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

• compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase-expected.html: Added.
• compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase-expected.html (added)
• LayoutTests/compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-02  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION(r260276): menu items in footer of https://salo.ai are invisible until you hover or resize
+        https://bugs.webkit.org/show_bug.cgi?id=213712
+        <rdar://problem/64893190>
+
+        Reviewed by Zalan Bujtas.
+
+        * compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase-expected.html: Added.
+        * compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html: Added.
+
 2020-07-02  Karl Rackler  <rackler@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-02  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION(r260276): menu items in footer of https://salo.ai are invisible until you hover or resize
+        https://bugs.webkit.org/show_bug.cgi?id=213712
+        <rdar://problem/64893190>
+
+        Reviewed by Zalan Bujtas.
+
+        A negative z-index child triggers a foreground layer inside overflow scroll. This foreground layer
+        gets the PaintingOverflowContents flag but not the PaintingCompositingScrollingPhase flag, but we still need
+        to avoid the clip check that happens in RenderBlock::paint(), so change RenderLayer::paintLayerContents()
+        to just check for isPaintingOverflowContents.
+
+        Test: compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::paintLayerContents):
+
 2020-07-02  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -4616 +4616 @@
             paintBehavior.add(PaintBehavior::TileFirstPaint);
 
-        if (isPaintingScrollingContent && isPaintingOverflowContents)
+        if (isPaintingOverflowContents)
             paintBehavior.add(PaintBehavior::CompositedOverflowScrollContent);