Changeset 264011 in webkit

Timestamp:

Jul 7, 2020, 12:21:16 AM (6 years ago)

Author:

yurys@chromium.org

Message:

[GTK][MiniBrowser] occasional crashes when closing while download in progress
​https://bugs.webkit.org/show_bug.cgi?id=214007

Reviewed by Carlos Garcia Campos.

Remove signal handlers from WebKitDownload when BrowserDownload is finalized,
WebKitDownload may emit a signal after the UI item has been destroyed which leads
to a crash.

• MiniBrowser/gtk/BrowserDownloadsBar.c:

(browserDownloadFinalize):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserDownloadsBar.c (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-07-07  Yury Semikhatsky  <yurys@chromium.org>
+
+        [GTK][MiniBrowser] occasional crashes when closing while download in progress
+        https://bugs.webkit.org/show_bug.cgi?id=214007
+
+        Reviewed by Carlos Garcia Campos.
+
+        Remove signal handlers from WebKitDownload when BrowserDownload is finalized,
+        WebKitDownload may emit a signal after the UI item has been destroyed which leads
+        to a crash.
+
+        * MiniBrowser/gtk/BrowserDownloadsBar.c:
+        (browserDownloadFinalize):
+
 2020-07-06  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c

@@ -128 +128 @@
 
     if (browserDownload->download) {
+        g_signal_handlers_disconnect_by_data(browserDownload->download, browserDownload);
         g_object_unref(browserDownload->download);
         browserDownload->download = NULL;