Changeset 264015 in webkit

Timestamp:

Jul 7, 2020, 6:56:37 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] WebProcess hangs when browsing GitHub
​https://bugs.webkit.org/show_bug.cgi?id=213970

Reviewed by Sergio Villar Senin.

Use a lower priority for LayerFlushTimer and DisplayRefreshMonitorTimer. We were using a very high priority for
drawing with the idea of keeping a good rendering performance without being affected by other timers. The
problem is that animations can be controlled by timers, so we need to ensure that MainThreadSharedTimer has
higher priority than drawing.

• wtf/glib/RunLoopSourcePriority.h: Use 110 for LayerFlushTimer and DisplayRefreshMonitorTimer.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/glib/RunLoopSourcePriority.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-07-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] WebProcess hangs when browsing GitHub
+        https://bugs.webkit.org/show_bug.cgi?id=213970
+
+        Reviewed by Sergio Villar Senin.
+
+        Use a lower priority for LayerFlushTimer and DisplayRefreshMonitorTimer. We were using a very high priority for
+        drawing with the idea of keeping a good rendering performance without being affected by other timers. The
+        problem is that animations can be controlled by timers, so we need to ensure that MainThreadSharedTimer has
+        higher priority than drawing.
+
+        * wtf/glib/RunLoopSourcePriority.h: Use 110 for LayerFlushTimer and DisplayRefreshMonitorTimer.
+
 2020-07-06  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WTF/wtf/glib/RunLoopSourcePriority.h

@@ -36 +36 @@
 // We don't use those macros here to avoid having to include glib header only
 // for this. But we should take into account that GLib uses G_PRIORITY_DEFAULT
-// for timeout sourcea and G_PRIORITY_DEFAULT_IDLE for idle sources.
+// for timeout sources and G_PRIORITY_DEFAULT_IDLE for idle sources.
 // Changes in these priorities can have a huge impact in performance, and in
 // the correctness too, so be careful when changing them.
@@ -62 +62 @@
 
     // Layer flush.
-    LayerFlushTimer = -100,
+    LayerFlushTimer = 110,
 
     // DisplayRefreshMonitor timer, should have the same value as the LayerFlushTimer.
-    DisplayRefreshMonitorTimer = -100,
+    DisplayRefreshMonitorTimer = 110,
 
     // Rendering timer in the main thread when accelerated compositing is not used.