Changeset 264017 in webkit

Timestamp:

Jul 7, 2020, 8:07:52 AM (6 years ago)

Author:

ggaren@apple.com

Message:

Added a test for callOnMainThread
​https://bugs.webkit.org/show_bug.cgi?id=214025

Reviewed by Sam Weinig.

This test failed prior to ​https://trac.webkit.org/changeset/263981.

• TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST): Added a test demonstrating why a simple "is the
queue empty?" check doesn't work when you support both re-entrancy and
threads. While the main thread is sleeping in a nested RunLoop, a
secondary thread can see a non-empty queue.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/RunLoop.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-07-07  Geoffrey Garen  <ggaren@apple.com>
+
+        Added a test for callOnMainThread
+        https://bugs.webkit.org/show_bug.cgi?id=214025
+
+        Reviewed by Sam Weinig.
+
+        This test failed prior to https://trac.webkit.org/changeset/263981.
+
+        * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
+        (TestWebKitAPI::TEST): Added a test demonstrating why a simple "is the
+        queue empty?" check doesn't work when you support both re-entrancy and
+        threads. While the main thread is sleeping in a nested RunLoop, a
+        secondary thread can see a non-empty queue.
+
 2020-07-07  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp

@@ -98 +98 @@
 }
 
+TEST(WTF_RunLoop, CallOnMainCrossThreadWhileNested)
+{
+    WTF::initializeMainThread();
+
+    bool done = false;
+
+    callOnMainThread([&done] {
+        Thread::create("CallOnMainCrossThread", [&done] {
+            callOnMainThread([&done] {
+                done = true;
+            });
+        });
+
+        Util::run(&done);
+    });
+    callOnMainThread([] { });
+
+    Util::run(&done);
+}
+
 class DerivedOneShotTimer : public RunLoop::Timer<DerivedOneShotTimer> {
 public: