Changeset 264103 in webkit

Timestamp:

Jul 8, 2020, 9:41:35 AM (6 years ago)

Author:

Alan Bujtas

Message:

[LFC][TFC] Table width is computed as if box-sizing was border-box
​https://bugs.webkit.org/show_bug.cgi?id=214070

Reviewed by Antti Koivisto.

Source/WebCore:

Apparently the width property of the <table> works as if box-sizing were set to border-box (and <div style="display: table" does not).

Test: fast/layoutformattingcontext/table-with-padding-and-border-simple.html

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildTableStructure):

LayoutTests:

• fast/layoutformattingcontext/table-with-padding-and-border-simple-expected.html: Added.
• fast/layoutformattingcontext/table-with-padding-and-border-simple.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/layoutformattingcontext/table-with-padding-and-border-simple-expected.html (added)
• LayoutTests/fast/layoutformattingcontext/table-with-padding-and-border-simple.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-08  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][TFC] Table width is computed as if box-sizing was border-box
+        https://bugs.webkit.org/show_bug.cgi?id=214070
+
+        Reviewed by Antti Koivisto.
+
+        * fast/layoutformattingcontext/table-with-padding-and-border-simple-expected.html: Added.
+        * fast/layoutformattingcontext/table-with-padding-and-border-simple.html: Added.
+
 2020-07-08  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-08  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][TFC] Table width is computed as if box-sizing was border-box
+        https://bugs.webkit.org/show_bug.cgi?id=214070
+
+        Reviewed by Antti Koivisto.
+
+        Apparently the width property of the <table> works as if box-sizing were set to border-box (and <div style="display: table" does not).
+
+        Test: fast/layoutformattingcontext/table-with-padding-and-border-simple.html
+
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::buildTableStructure):
+
 2020-07-07  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp

@@ -35 +35 @@
 #include "HTMLTableCellElement.h"
 #include "HTMLTableColElement.h"
+#include "HTMLTableElement.h"
 #include "InlineFormattingState.h"
 #include "InvalidationContext.h"
@@ -316 +317 @@
     tableBoxStyle.setFloating(Float::No);
     tableBoxStyle.resetMargin();
+    // FIXME: Figure out where the spec says table width is like box-sizing: border-box;
+    if (is<HTMLTableElement>(tableRenderer.element()))
+        tableBoxStyle.setBoxSizing(BoxSizing::BorderBox);
     auto& tableBox = createContainer(Box::ElementAttributes { Box::ElementType::TableBox }, WTFMove(tableBoxStyle));
     appendChild(tableWrapperBox, tableBox);