Changeset 264162 in webkit

Timestamp:

Jul 9, 2020, 2:24:58 AM (6 years ago)

Author:

Philippe Normand

Message:

[GStreamer][MSE] AV1 support
​https://bugs.webkit.org/show_bug.cgi?id=207547

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

If only the av1dec decoder is available, consider AV1 decoding
support as disabled, because this plugin performs really badly.
However, if any other AV1 decoder is present, such as the
dav1d-based Rust decoder for instance, consider AV1 support as
enabled.

These checks are now performed by both RegistryScanner instances,
for MSE and non-MSE players.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::initialize):

• platform/graphics/gstreamer/GStreamerRegistryScanner.h:

LayoutTests:

• platform/glib/TestExpectations: Mark media/media-can-play-av1.html as failing until the

Flatpak SDK ships gst-plugins-rs.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp (modified) (6 diffs)
• Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-09  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer][MSE] AV1 support
+        https://bugs.webkit.org/show_bug.cgi?id=207547
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/glib/TestExpectations: Mark media/media-can-play-av1.html as failing until the
+        Flatpak SDK ships gst-plugins-rs.
+
 2020-07-09  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/LayoutTests/platform/glib/TestExpectations

@@ -159 +159 @@
 
 webkit.org/b/214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html [ ImageOnlyFailure ]
+
+webkit.org/b/207547 media/media-can-play-av1.html [ Failure ]
 
 #////////////////////////////////////////////////////////////////////////////////////////

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-09  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer][MSE] AV1 support
+        https://bugs.webkit.org/show_bug.cgi?id=207547
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        If only the av1dec decoder is available, consider AV1 decoding
+        support as disabled, because this plugin performs really badly.
+        However, if any other AV1 decoder is present, such as the
+        dav1d-based Rust decoder for instance, consider AV1 support as
+        enabled.
+
+        These checks are now performed by both RegistryScanner instances,
+        for MSE and non-MSE players.
+
+        * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
+        (WebCore::GStreamerRegistryScanner::hasElementForMediaType const):
+        (WebCore::GStreamerRegistryScanner::initialize):
+        * platform/graphics/gstreamer/GStreamerRegistryScanner.h:
+
 2020-07-09  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

@@ -68 +68 @@
 }
 
-GStreamerRegistryScanner::RegistryLookupResult GStreamerRegistryScanner::hasElementForMediaType(GList* elementFactories, const char* capsString, bool shouldCheckHardwareClassifier) const
+GStreamerRegistryScanner::RegistryLookupResult GStreamerRegistryScanner::hasElementForMediaType(GList* elementFactories, const char* capsString, bool shouldCheckHardwareClassifier, Optional<Vector<String>> blackList) const
 {
     GRefPtr<GstCaps> caps = adoptGRef(gst_caps_from_string(capsString));
@@ -74 +74 @@
     bool isSupported = candidates;
     bool isUsingHardware = false;
+
+    if (blackList.hasValue() && !blackList->isEmpty()) {
+        bool hasValidCandidate = false;
+        for (GList* factories = candidates; factories; factories = g_list_next(factories)) {
+            String name(gst_plugin_feature_get_name(GST_PLUGIN_FEATURE_CAST(factories->data)));
+            if (blackList->contains(name))
+                continue;
+            hasValidCandidate = true;
+            break;
+        }
+        if (!hasValidCandidate) {
+            GST_WARNING("All elements for caps %" GST_PTR_FORMAT " are blacklisted", caps.get());
+            isSupported = false;
+            shouldCheckHardwareClassifier = false;
+        }
+    }
 
     if (shouldCheckHardwareClassifier) {
@@ -160 +176 @@
     }
 
-    if (hasElementForMediaType(m_demuxerFactories, "video/x-matroska")) {
+    bool matroskaSupported = hasElementForMediaType(m_demuxerFactories, "video/x-matroska");
+    if (matroskaSupported) {
         auto vp8DecoderAvailable = hasElementForMediaType(m_videoDecoderFactories, "video/x-vp8", true);
         auto vp9DecoderAvailable = hasElementForMediaType(m_videoDecoderFactories, "video/x-vp9", true);
@@ -189 +206 @@
         m_codecMap.add(AtomString("avc*"), h264DecoderAvailable.isUsingHardware);
         m_codecMap.add(AtomString("mp4v*"), h264DecoderAvailable.isUsingHardware);
+    }
+
+    Vector<String> av1DecodersBlacklist { "av1dec"_s };
+    if ((matroskaSupported || isContainerTypeSupported("video/mp4")) && hasElementForMediaType(m_videoDecoderFactories, "video/x-av1", false, makeOptional(WTFMove(av1DecodersBlacklist)))) {
+        m_codecMap.add(AtomString("av01*"), false);
+        m_codecMap.add(AtomString("x-av1"), false);
     }
 
@@ -263 +286 @@
     }
 
-    bool matroskaSupported = hasElementForMediaType(m_demuxerFactories, "video/x-matroska");
     if (matroskaSupported) {
         m_mimeTypeSet.add(AtomString("video/x-matroska"));
@@ -270 +292 @@
             m_mimeTypeSet.add(AtomString("video/webm"));
     }
-
-    if ((matroskaSupported || isContainerTypeSupported("video/mp4")) && hasElementForMediaType(m_videoDecoderFactories, "video/x-av1"))
-        m_codecMap.add(AtomString("av01*"), false);
 }
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h

@@ -75 +75 @@
     void fillMimeTypeSetFromCapsMapping(Vector<GstCapsWebKitMapping>&);
 
-    RegistryLookupResult hasElementForMediaType(GList* elementFactories, const char* capsString, bool shouldCheckHardwareClassifier = false) const;
+    RegistryLookupResult hasElementForMediaType(GList* elementFactories, const char* capsString, bool shouldCheckHardwareClassifier = false, Optional<Vector<String>> blackList = WTF::nullopt) const;
 
     bool isAVC1CodecSupported(const String& codec, bool shouldCheckForHardwareUse) const;