Changeset 264166 in webkit

Timestamp:

Jul 9, 2020, 5:30:22 AM (6 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Don't cache duration in MediaSourceClientGStreamerMSE
​https://bugs.webkit.org/show_bug.cgi?id=214128

Reviewed by Xabier Rodriguez-Calvar.

MediaSource should be the single source of truth for the duration of
the MediaSource, and querying it to MediaSource is efficient enough
(trivial getter). There is no reason for MediaSourceClientGStreamerMSE
to store a separate m_duration field.

This patch introduces no behavior changes.

• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::MediaSourceClientGStreamerMSE):
(WebCore::MediaSourceClientGStreamerMSE::duration):
(WebCore::MediaSourceClientGStreamerMSE::durationChanged):

• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp (modified) (3 diffs)
• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-09  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Don't cache duration in MediaSourceClientGStreamerMSE
+        https://bugs.webkit.org/show_bug.cgi?id=214128
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        MediaSource should be the single source of truth for the duration of
+        the MediaSource, and querying it to MediaSource is efficient enough
+        (trivial getter). There is no reason for MediaSourceClientGStreamerMSE
+        to store a separate m_duration field.
+
+        This patch introduces no behavior changes.
+
+        * platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
+        (WebCore::MediaSourceClientGStreamerMSE::MediaSourceClientGStreamerMSE):
+        (WebCore::MediaSourceClientGStreamerMSE::duration):
+        (WebCore::MediaSourceClientGStreamerMSE::durationChanged):
+        * platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
+
 2020-07-09  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp

@@ -47 +47 @@
 MediaSourceClientGStreamerMSE::MediaSourceClientGStreamerMSE(MediaPlayerPrivateGStreamerMSE& playerPrivate)
     : m_playerPrivate(playerPrivate)
-    , m_duration(MediaTime::invalidTime())
 {
     ASSERT(WTF::isMainThread());
@@ -71 +70 @@
 }
 
-const MediaTime& MediaSourceClientGStreamerMSE::duration()
+MediaTime MediaSourceClientGStreamerMSE::duration()
 {
     ASSERT(WTF::isMainThread());
 
-    return m_duration;
+    return m_playerPrivate.mediaSourcePrivateClient()->duration();
 }
 
@@ -86 +85 @@
         return;
 
-    m_duration = duration;
     m_playerPrivate.durationChanged();
 }

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h

@@ -55 +55 @@
     void allSamplesInTrackEnqueued(const AtomString&);
 
-    const MediaTime& duration();
+    MediaTime duration();
     GRefPtr<WebKitMediaSrc> webKitMediaSrc();
 
@@ -62 +62 @@
 
     MediaPlayerPrivateGStreamerMSE& m_playerPrivate;
-    MediaTime m_duration;
 };