Changeset 264298 in webkit

Timestamp:

Jul 13, 2020, 5:17:04 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[WPE][GTK4] Form controls are not painted when using threaded rendering
​https://bugs.webkit.org/show_bug.cgi?id=214178

Reviewed by Žan Doberšek.

Which is the default for GTK4 since r263888. The problem is that RenderTheme::paint() returns early if the given
GraphicsContext doesn't have a platform context, assuming all RenderTheme implementations paint directly to the
platform context. This patch adds a pure virtual canPaint() to RenderTheme to be used as the early return.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

• rendering/RenderTheme.h:
• rendering/RenderThemeAdwaita.h:
• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::canPaint const):

• rendering/RenderThemePlayStation.h:
• rendering/RenderThemeWin.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderTheme.cpp (modified) (1 diff)
• rendering/RenderTheme.h (modified) (1 diff)
• rendering/RenderThemeAdwaita.h (modified) (1 diff)
• rendering/RenderThemeCocoa.h (modified) (1 diff)
• rendering/RenderThemeCocoa.mm (modified) (1 diff)
• rendering/RenderThemePlayStation.h (modified) (1 diff)
• rendering/RenderThemeWin.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [WPE][GTK4] Form controls are not painted when using threaded rendering
+        https://bugs.webkit.org/show_bug.cgi?id=214178
+
+        Reviewed by Žan Doberšek.
+
+        Which is the default for GTK4 since r263888. The problem is that RenderTheme::paint() returns early if the given
+        GraphicsContext doesn't have a platform context, assuming all RenderTheme implementations paint directly to the
+        platform context. This patch adds a pure virtual canPaint() to RenderTheme to be used as the early return.
+
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::paint):
+        * rendering/RenderTheme.h:
+        * rendering/RenderThemeAdwaita.h:
+        * rendering/RenderThemeCocoa.h:
+        * rendering/RenderThemeCocoa.mm:
+        (WebCore::RenderThemeCocoa::canPaint const):
+        * rendering/RenderThemePlayStation.h:
+        * rendering/RenderThemeWin.h:
+
 2020-07-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/rendering/RenderTheme.cpp

@@ -296 +296 @@
         return false;
 
-    if (UNLIKELY(!paintInfo.context().hasPlatformContext()))
+    if (UNLIKELY(!canPaint(paintInfo)))
         return false;
 

trunk/Source/WebCore/rendering/RenderTheme.h

@@ -277 +277 @@
 
 protected:
+    virtual bool canPaint(const PaintInfo&) const = 0;
     virtual FontCascadeDescription& cachedSystemFontDescription(CSSValueID systemFontID) const;
     virtual void updateCachedSystemFontDescription(CSSValueID systemFontID, FontCascadeDescription&) const = 0;

trunk/Source/WebCore/rendering/RenderThemeAdwaita.h

@@ -35 +35 @@
 
 private:
+    bool canPaint(const PaintInfo&) const final { return true; }
+
     String extraDefaultStyleSheet() final;
 #if ENABLE(VIDEO)

trunk/Source/WebCore/rendering/RenderThemeCocoa.h

@@ -40 +40 @@
 
 private:
+    bool canPaint(const PaintInfo&) const final;
     bool shouldHaveCapsLockIndicator(const HTMLInputElement&) const final;
 

trunk/Source/WebCore/rendering/RenderThemeCocoa.mm

@@ -53 +53 @@
 {
     return static_cast<RenderThemeCocoa&>(RenderTheme::singleton());
+}
+
+bool RenderThemeCocoa::canPaint(const PaintInfo& paintInfo) const
+{
+    return paintInfo.context().hasPlatformContext();
 }
 

trunk/Source/WebCore/rendering/RenderThemePlayStation.h

@@ -35 +35 @@
 
 private:
+    bool canPaint(const PaintInfo&) const final { return true; }
+
     void updateCachedSystemFontDescription(CSSValueID systemFontID, FontCascadeDescription&) const final;
 };

trunk/Source/WebCore/rendering/RenderThemeWin.h

@@ -142 +142 @@
     virtual ~RenderThemeWin();
 
+    bool canPaint(const PaintInfo&) const final { return true; }
+
     // System fonts.
     void updateCachedSystemFontDescription(CSSValueID, FontCascadeDescription&) const override;