Changeset 264307 in webkit

Timestamp:

Jul 13, 2020, 12:00:09 PM (6 years ago)

Author:

Brent Fulgham

Message:

REGRESSION (r262538): Nullptr Deref in WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::performDailyTasks()::$_66, void>::call
​https://bugs.webkit.org/show_bug.cgi?id=214264
<rdar://problem/65093949>

Reviewed by Darin Adler.

A new type check was added outside of the protecting nullptr check. This introduced
a new nullptr dereference bug.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-07-13  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION (r262538): Nullptr Deref in WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::performDailyTasks()::$_66, void>::call
+        https://bugs.webkit.org/show_bug.cgi?id=214264
+        <rdar://problem/65093949>
+
+        Reviewed by Darin Adler.
+
+        A new type check was added outside of the protecting nullptr check. This introduced
+        a new nullptr dereference bug.
+
+        * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
+        (WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
+
 2020-07-13  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp

@@ -756 +756 @@
             m_statisticsStore->includeTodayAsOperatingDateIfNecessary();
             m_statisticsStore->calculateAndSubmitTelemetry();
-        }
-        if (is<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore))
-            downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runIncrementalVacuumCommand();
+            if (is<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore))
+                downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runIncrementalVacuumCommand();
+        }
     });
 }