Changeset 264489 in webkit

Timestamp:

Jul 16, 2020, 6:00:45 PM (6 years ago)

Author:

pvollan@apple.com

Message:

XPC connection should be suspended before setting target queue
​https://bugs.webkit.org/show_bug.cgi?id=214427

Reviewed by Darin Adler.

Source/WebKit:

According to system logs, an active XPC connection should be suspended before setting a new target queue.

No new tests, since there should be no behavior change introduced by this patch.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::handleXPCEndpointMessages const):

Source/WTF:

Declare function to suspend XPC connection.

• wtf/spi/darwin/XPCSPI.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/spi/darwin/XPCSPI.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebProcess/cocoa/WebProcessCocoa.mm (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-07-16  Per Arne Vollan  <pvollan@apple.com>
+
+        XPC connection should be suspended before setting target queue
+        https://bugs.webkit.org/show_bug.cgi?id=214427
+
+        Reviewed by Darin Adler.
+
+        Declare function to suspend XPC connection.
+
+        * wtf/spi/darwin/XPCSPI.h:
+
 2020-07-16  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WTF/wtf/spi/darwin/XPCSPI.h

@@ -128 +128 @@
 pid_t xpc_connection_get_pid(xpc_connection_t);
 void xpc_connection_resume(xpc_connection_t);
+void xpc_connection_suspend(xpc_connection_t);
 void xpc_connection_send_message(xpc_connection_t, xpc_object_t);
 void xpc_connection_send_message_with_reply(xpc_connection_t, xpc_object_t, dispatch_queue_t, xpc_handler_t);

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-07-16  Per Arne Vollan  <pvollan@apple.com>
+
+        XPC connection should be suspended before setting target queue
+        https://bugs.webkit.org/show_bug.cgi?id=214427
+
+        Reviewed by Darin Adler.
+
+        According to system logs, an active XPC connection should be suspended before setting a new target queue.
+
+        No new tests, since there should be no behavior change introduced by this patch.
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::handleXPCEndpointMessages const):
+
 2020-07-16  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -172 +172 @@
     auto connection = parentProcessConnection()->xpcConnection();
 
+    xpc_connection_suspend(connection);
+
     xpc_connection_set_target_queue(connection, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0));
     xpc_connection_set_event_handler(connection, ^(xpc_object_t event) {
@@ -187 +189 @@
         }
     });
+
+    xpc_connection_resume(connection);
 }