Changeset 264747 in webkit

Timestamp:

Jul 22, 2020, 9:52:32 PM (6 years ago)

Author:

jer.noble@apple.com

Message:

[Cocoa] Add feature flag for WebM & VP9
​https://bugs.webkit.org/show_bug.cgi?id=214672
<rdar://problem/65959506>

Reviewed by Beth Dakin.

Source/WebKit:

• FeatureFlags/WebKit.plist:
• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultVP9DecoderEnabled):
(WebKit::defaultWebMParserEnabled):

• Shared/WebPreferencesDefaultValues.h:

Source/WTF:

• wtf/PlatformEnableCocoa.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/FeatureFlags/WebKit.plist (modified) (1 diff)
• WebKit/Shared/WebPreferences.yaml (modified) (1 diff)
• WebKit/Shared/WebPreferencesDefaultValues.cpp (modified) (1 diff)
• WebKit/Shared/WebPreferencesDefaultValues.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-07-22  Jer Noble  <jer.noble@apple.com>
+
+        [Cocoa] Add feature flag for WebM & VP9
+        https://bugs.webkit.org/show_bug.cgi?id=214672
+        <rdar://problem/65959506>
+
+        Reviewed by Beth Dakin.
+
+        * wtf/PlatformEnableCocoa.h:
+
 2020-07-22  Conrad Shultz  <conrad_shultz@apple.com>
 

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -531 +531 @@
 #endif
 
+#if !defined(ENABLE_VP9) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
+#define ENABLE_VP9 1
+#endif
+
 #if !defined(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS)
 #define ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS 1

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-07-22  Jer Noble  <jer.noble@apple.com>
+
+        [Cocoa] Add feature flag for WebM & VP9
+        https://bugs.webkit.org/show_bug.cgi?id=214672
+        <rdar://problem/65959506>
+
+        Reviewed by Beth Dakin.
+
+        * FeatureFlags/WebKit.plist:
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultVP9DecoderEnabled):
+        (WebKit::defaultWebMParserEnabled):
+        * Shared/WebPreferencesDefaultValues.h:
+
 2020-07-22  Conrad Shultz  <conrad_shultz@apple.com>
 

trunk/Source/WebKit/FeatureFlags/WebKit.plist

@@ -48 +48 @@
         <false/>
     </dict>
+    <key>vp9_decoder</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>webm_parser</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
 </dict>
 </plist>

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -663 +663 @@
 VP9DecoderEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: defaultVP9DecoderEnabled()
   webcoreBinding: none
   humanReadableName: "VP9 decoder"
   humanReadableDescription: "Enable VP9 decoder"
   category: experimental
+  condition: ENABLE(VP9)
 
 WebMParserEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: defaultWebMParserEnabled()
   webcoreBinding: RuntimeEnabledFeatures
   humanReadableName: "WebM MSE parser"
   humanReadableDescription: "Enable WebM MSE parser"
   category: experimental
-  condition: ENABLE(MEDIA_SOURCE)
+  condition: ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
 
 UseLegacyTextAlignPositionedElementBehavior:

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@ -244 +244 @@
 #endif // ENABLE(WEBXR)
 
+#if ENABLE(VP9)
+bool defaultVP9DecoderEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+    return isFeatureFlagEnabled("vp9_decoder");
+#endif
+
+    return true;
+}
+#endif
+
+#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+bool defaultWebMParserEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+    return isFeatureFlagEnabled("webm_parser");
+#endif
+
+    return true;
+}
+#endif
+
 } // namespace WebKit

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

@@ -363 +363 @@
 #endif
 
+#if ENABLE(VP9)
+bool defaultVP9DecoderEnabled();
+#endif
+
+#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+bool defaultWebMParserEnabled();
+#endif
+
 } // namespace WebKit