Changeset 264758 in webkit

Timestamp:

Jul 23, 2020, 5:51:51 AM (6 years ago)

Author:

Caio Lima

Message:

[32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm
​https://bugs.webkit.org/show_bug.cgi?id=214641

Reviewed by Mark Lam.

Adjusting the return of doVMEntry for 32-bits LLInt to proper set
EncodedJSValue return in little-endian architectures. It is expected
that tag is stored in r1 and payload is stored in r0.

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• llint/LowLevelInterpreter.asm (modified) (1 diff)
• llint/LowLevelInterpreter32_64.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-07-23  Caio Lima  <ticaiolima@gmail.com>
+
+        [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm
+        https://bugs.webkit.org/show_bug.cgi?id=214641
+
+        Reviewed by Mark Lam.
+
+        Adjusting the return of `doVMEntry` for 32-bits LLInt to proper set
+        `EncodedJSValue` return in little-endian architectures. It is expected
+        that tag is stored in `r1` and payload is stored in `r0`.
+
+        * llint/LowLevelInterpreter.asm:
+        * llint/LowLevelInterpreter32_64.asm:
+
 2020-07-23  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

@@ -2188 +2188 @@
             # parameters as CallFrame* and EncodedJSValue,
             # we need to store call result on a2, a3 and call frame on a0,
-            # leaving a1 as dummy value.
+            # leaving a1 as dummy value (this calling convention is considered only
+            # for little-endian architectures).
             move r1, a3
             move r0, a2

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

@@ -328 +328 @@
     move protoCallFrame, a1
     cCall2(_llint_check_vm_entry_permission)
-    move UndefinedTag, r0
-    move 0, r1
+
+    # Tag is stored in r1 and payload is stored in r0 in little-endian architectures.
+    move UndefinedTag, r1
+    move 0, r0
 
     subp cfr, CalleeRegisterSaveSize, sp