Changeset 265437 in webkit

Timestamp:

Aug 10, 2020, 10:49:01 AM (6 years ago)

Author:

eric.carlson@apple.com

Message:

r262456 broke sites that expect webkitDisplayingFullscreen to be true almost immediately
​https://bugs.webkit.org/show_bug.cgi?id=215240
<rdar://problem/66284042>

Reviewed by Darin Adler.

Add a quirk for sites that use the Akamai Media Player, which begins polling
webkitDisplayingFullscreen every 100ms immediately after entering video fullscreen
mode and exits fullscreen as soon as it returns false. r262456 changed the HTMLMediaPlayer
state machine so webkitDisplayingFullscreen doesn't return true until the fullscreen
window has been opened in the UI process. This was done to fix bugs triggered by
rapidly entering and exiting fullscreen and PiP and make our own fullscreen/PiP tests
less flakey, so instead of reverting the change universally do it as a quirk for sites
using the Akamai Media Player.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitDisplayingFullscreen):

• page/Quirks.cpp:

(WebCore::Quirks::needsAkamaiMediaPlayerQuirk const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLVideoElement.cpp (modified) (1 diff)
• page/Quirks.cpp (modified) (2 diffs)
• page/Quirks.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-08-10  Eric Carlson  <eric.carlson@apple.com>
+
+        r262456 broke sites that expect webkitDisplayingFullscreen to be true almost immediately
+        https://bugs.webkit.org/show_bug.cgi?id=215240
+        <rdar://problem/66284042>
+
+        Reviewed by Darin Adler.
+
+        Add a quirk for sites that use the Akamai Media Player, which begins polling
+        `webkitDisplayingFullscreen` every 100ms immediately after entering video fullscreen
+        mode and exits fullscreen as soon as it returns false. r262456 changed the HTMLMediaPlayer
+        state machine so `webkitDisplayingFullscreen` doesn't return `true` until the fullscreen
+        window has been opened in the UI process. This was done to fix bugs triggered by
+        rapidly entering and exiting fullscreen and PiP and make our own fullscreen/PiP tests
+        less flakey, so instead of reverting the change universally do it as a quirk for sites
+        using the Akamai Media Player.
+
+        * html/HTMLVideoElement.cpp:
+        (WebCore::HTMLVideoElement::webkitDisplayingFullscreen):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsAkamaiMediaPlayerQuirk const):
+        * page/Quirks.h:
+
 2020-08-10  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/html/HTMLVideoElement.cpp

@@ -353 +353 @@
 bool HTMLVideoElement::webkitDisplayingFullscreen()
 {
+    if (document().quirks().needsAkamaiMediaPlayerQuirk(*this))
+        return isFullscreen() || m_isChangingPresentationMode;
+
     // This function starts to return true after the video element has entered
     // fullscreen/picture-in-picture until it has exited fullscreen/picture-in-picture

trunk/Source/WebCore/page/Quirks.cpp

@@ -39 +39 @@
 #include "HTMLMetaElement.h"
 #include "HTMLObjectElement.h"
+#include "HTMLVideoElement.h"
 #include "JSEventListener.h"
 #include "LayoutUnit.h"
@@ -984 +985 @@
 }
 
-
-}
+// FIXME: remove this once rdar://66739450 has been fixed.
+bool Quirks::needsAkamaiMediaPlayerQuirk(const HTMLVideoElement& element) const
+{
+#if PLATFORM(IOS_FAMILY)
+    // Akamai Media Player begins polling `webkitDisplayingFullscreen` every 100ms immediately after calling
+    // `webkitEnterFullscreen` and exits fullscreen as soon as it returns false. r262456 changed the HTMLMediaPlayer state
+    // machine so `webkitDisplayingFullscreen` doesn't return true until the fullscreen window has been opened in the
+    // UI process, which causes Akamai Media Player to frequently exit fullscreen mode immediately.
+
+    static NeverDestroyed<const AtomString> akamaiHTML5(MAKE_STATIC_STRING_IMPL("akamai-html5"));
+    static NeverDestroyed<const AtomString> akamaiMediaElement(MAKE_STATIC_STRING_IMPL("akamai-media-element"));
+
+    if (!needsQuirks())
+        return false;
+
+    if (!element.hasClass())
+        return false;
+
+    auto& classNames = element.classNames();
+    return classNames.contains(akamaiHTML5) && classNames.contains(akamaiMediaElement);
+#else
+    UNUSED_PARAM(element);
+    return false;
+#endif
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -111 +111 @@
     bool needsVP9FullRangeFlagQuirk() const;
     bool needsHDRPixelDepthQuirk() const;
+    
+    bool needsAkamaiMediaPlayerQuirk(const HTMLVideoElement&) const;
 
 private: