Changeset 265780 in webkit

Timestamp:

Aug 17, 2020, 4:12:59 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215353

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-17
Reviewed by Jon Lee.

GCController.collect() is flaky. Calling this function from JS does not
guarantee the memory of all the deallocated objects is garbage-collected.
Multiple calls to GCController.collect() may be invoked to overcome this
problem. Putting idle time before requesting the numberOfLiveNodes()
might be needed as well.

The test adds 100 <use> elements. Each of them references a <rect> element
and adds an <animate> element to animate the 'x' property. This is a big
number of objects to be allocated, deallocated and garbage collected. To
overcome the flakiness of GCController.collect(), three <use> elements
can be added instead. This number of objects should be enough to test the
SVG animated properties do not leak. And at the same time the test won't
exercise the flakiness of GCController.collect().

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• svg/animations/smil-leak-element-instances-noBaseValRef.svg:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/ios-wk2/TestExpectations (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)
• svg/animations/smil-leak-element-instances-noBaseValRef.svg (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-08-17  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        [ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=215353
+
+        Reviewed by Jon Lee.
+
+        GCController.collect() is flaky. Calling this function from JS does not
+        guarantee the memory of all the deallocated objects is garbage-collected.
+        Multiple calls to GCController.collect() may be invoked to overcome this
+        problem. Putting idle time before requesting the numberOfLiveNodes()
+        might be needed as well.
+
+        The test adds 100 <use> elements. Each of them references a <rect> element
+        and adds an <animate> element to animate the 'x' property. This is a big
+        number of objects to be allocated, deallocated and garbage collected. To
+        overcome the flakiness of GCController.collect(), three <use> elements
+        can be added instead. This number of objects should be enough to test the
+        SVG animated properties do not leak. And at the same time the test won't
+        exercise the flakiness of GCController.collect().
+
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        * svg/animations/smil-leak-element-instances-noBaseValRef.svg:
+
 2020-08-17  Hector Lopez  <hector_i_lopez@apple.com>
 

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -1846 +1846 @@
 webkit.org/b/215351 http/wpt/service-workers/module-meta-url-fragment.https.html [ Pass Failure ]
 
-webkit.org/b/245353 [ Debug ] svg/animations/smil-leak-element-instances-noBaseValRef.svg [ Pass Failure ]
-
 webkit.org/b/208832 imported/w3c/web-platform-tests/webmessaging/Channel_postMessage_Blob.htm [ Pass Failure ]
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -1096 +1096 @@
 webkit.org/b/215304 fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button.html [ Pass Failure ]
 
-webkit.org/b/245353 [ Release ] svg/animations/smil-leak-element-instances-noBaseValRef.svg [ Pass Failure ]
-
 webkit.org/b/215465 [ Debug ] http/tests/security/no-indexeddb-from-sandbox.html [ Crash ]
 

trunk/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

@@ -38 +38 @@
     originalLiveElements = window.internals.numberOfLiveNodes();
 
-    for (var i = 0; i < 100; i++)
+    for (var i = 0; i < 3; i++)
         g.appendChild(createAnimatedRectInstance());