Changeset 26616 in webkit


Ignore:
Timestamp:
Oct 15, 2007, 12:02:41 PM (17 years ago)
Author:
darin
Message:

WebCore:

Reviewed by Sam.

Test: fast/dom/Window/alert-undefined.html

  • page/DOMWindow.idl: Remove ConvertUndefinedOrNullToNullString from alert, confirm, and prompt. It turns out that the default behavior is what the other browsers do (browsers tested: IE 7, Firefox 2).

LayoutTests:

Reviewed by Sam.

  • fast/dom/Window/alert-undefined.html: Added tests of null and both confirm and prompt.
  • fast/dom/Window/alert-undefined-expected.txt: Updated.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r26614 r26616  
     12007-10-15  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Sam.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15520
     6          alert(undefined) should say "undefined" in the alert
     7
     8        * fast/dom/Window/alert-undefined.html: Added tests of null and both confirm and prompt.
     9        * fast/dom/Window/alert-undefined-expected.txt: Updated.
     10
    1112007-10-15  Adele Peterson  <adele@apple.com>
    212

  • trunk/LayoutTests/fast/dom/Window/alert-undefined-expected.txt

    r24371 r26616  
    1 ALERT:
    2 The alert that shows up (or if this is running under DRT, that is dumped) should be blank and not contain the text "undefined".
    3 
    4 
     1ALERT: undefined
     2ALERT: null
     3CONFIRM: undefined
     4CONFIRM: null
     5PROMPT: undefined, default text: undefined
     6PROMPT: null, default text: undefined
     7ALERT: undefined
     8CONFIRM: undefined
     9PROMPT: undefined, default text: undefined
     10The alerts that show up (or if this is running under DRT, that is dumped) should contain text; none should be empty. This isn't entirely consistent with other browsers in every case, but since there's no real use case for this, it's best to be explicit rather than subtle and empty.

  • trunk/LayoutTests/fast/dom/Window/alert-undefined.html

    r24371 r26616  
    88                layoutTestController.dumpAsText();
    99
     10            alert(undefined);
     11            alert(null);
     12            confirm(undefined);
     13            confirm(null);
     14            prompt(undefined);
     15            prompt(null);
     16
    1017            alert();
     18            confirm();
     19            prompt();
    1120        }
    1221    </script>
    1322</head>
    14 <body onload="runTests();">
    15     <p>The alert that shows up (or if this is running under DRT, that is dumped) should be blank and not contain the text "undefined".</p>
    16     <pre id="console"></pre>
     23<body onload="runTests()">
     24    <p>The alerts that show up (or if this is running under DRT, that is dumped) should contain text; none should be empty.
     25    This isn't entirely consistent with other browsers in every case, but since there's no real use case for this,
     26    it's best to be explicit rather than subtle and empty.</p>
    1727</body>
    1828</html>

  • trunk/WebCore/ChangeLog

    r26614 r26616  
     12007-10-15  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Sam.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15520
     6          alert(undefined) should say "undefined" in the alert
     7
     8        Test: fast/dom/Window/alert-undefined.html
     9
     10        * page/DOMWindow.idl: Remove ConvertUndefinedOrNullToNullString from alert, confirm, and prompt.
     11        It turns out that the default behavior is what the other browsers do (browsers tested: IE 7,
     12        Firefox 2).
     13
    1142007-10-15  Adele Peterson  <adele@apple.com>
    215

  • trunk/WebCore/page/DOMWindow.idl

    r26569 r26616  
    4848        void stop();
    4949
    50         void alert(in [ConvertUndefinedOrNullToNullString] DOMString message);
    51         boolean confirm(in [ConvertUndefinedOrNullToNullString] DOMString message);
    52         [ConvertNullStringTo=Null] DOMString prompt(in [ConvertUndefinedOrNullToNullString] DOMString message,
    53                                                     in [ConvertUndefinedOrNullToNullString] DOMString defaultValue);
     50        void alert(in DOMString message);
     51        boolean confirm(in DOMString message);
     52        [ConvertNullStringTo=Null] DOMString prompt(in DOMString message, in DOMString defaultValue);
    5453
    5554        boolean find(in DOMString string,
Note: See TracChangeset for help on using the changeset viewer.