Changeset 266584 in webkit

Timestamp:

Sep 4, 2020, 4:14:48 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GLIB] Stop using firefox user agent quirk for google docs
​https://bugs.webkit.org/show_bug.cgi?id=215845

Reviewed by Adrian Perez de Castro.

Source/WebCore:

It causes problems with the CSP headers when accounts.youtube.com is used by google login and it no longer works
for google docs in any case.

• platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

Tools:

Update API tests. Bring back UserAgentQuirks.cpp to the build that was removed in r244857.

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/PlatformWPE.cmake:
• TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/UserAgentQuirks.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/PlatformGTK.cmake (modified) (1 diff)
• Tools/TestWebKitAPI/PlatformWPE.cmake (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-04  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GLIB] Stop using firefox user agent quirk for google docs
+        https://bugs.webkit.org/show_bug.cgi?id=215845
+
+        Reviewed by Adrian Perez de Castro.
+
+        It causes problems with the CSP headers when accounts.youtube.com is used by google login and it no longer works
+        for google docs in any case.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::isGoogle):
+        (WebCore::urlRequiresFirefoxBrowser):
+
 2020-09-03  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -39 +39 @@
 {
     String domain = url.host().toString();
+
+    // Google uses accounts.youtube.com for its login service.
+    if (domain == "accounts.youtube.com")
+        return true;
+
     String baseDomain = topPrivatelyControlledDomain(domain);
 
@@ -93 +98 @@
 {
     String domain = url.host().toString();
-
-    // This quirk actually has nothing to do with YouTube. It's needed to avoid
-    // unsupported browser warnings on Google Docs. After removing this quirk,
-    // to reproduce the warnings you will need to sign out of Google, then click
-    // on a link to a non-public document that requires signing in. The
-    // unsupported browser warning will be displayed after signing in.
-    if (domain == "accounts.youtube.com" || domain == "docs.google.com")
-        return true;
 
     // Google Drive shows an unsupported browser warning with WebKitGTK's

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-04  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GLIB] Stop using firefox user agent quirk for google docs
+        https://bugs.webkit.org/show_bug.cgi?id=215845
+
+        Reviewed by Adrian Perez de Castro.
+
+        Update API tests. Bring back UserAgentQuirks.cpp to the build that was removed in r244857.
+
+        * TestWebKitAPI/PlatformGTK.cmake:
+        * TestWebKitAPI/PlatformWPE.cmake:
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2020-09-03  James Darpinian  <jdarpinian@chromium.org>
 

trunk/Tools/TestWebKitAPI/PlatformGTK.cmake

@@ -33 +33 @@
     ${test_main_SOURCES}
 
+    Tests/WebCore/UserAgentQuirks.cpp
     Tests/WebCore/gstreamer/GStreamerTest.cpp
     Tests/WebCore/gstreamer/GstMappedBuffer.cpp

trunk/Tools/TestWebKitAPI/PlatformWPE.cmake

@@ -29 +29 @@
     ${test_main_SOURCES}
 
+    Tests/WebCore/UserAgentQuirks.cpp
     Tests/WebCore/gstreamer/GStreamerTest.cpp
     Tests/WebCore/gstreamer/GstMappedBuffer.cpp

trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

@@ -96 +96 @@
     assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
 
-    assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
-    assertUserAgentForURLHasFirefoxBrowserQuirk("http://docs.google.com/");
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://drive.google.com/");
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://bugzilla.redhat.com/");
@@ -107 +105 @@
     assertUserAgentForURLHasLinuxPlatformQuirk("http://drive.google.com/");
     assertUserAgentForURLHasLinuxPlatformQuirk("http://fonts.googleapis.com/");
+    assertUserAgentForURLHasLinuxPlatformQuirk("http://accounts.youtube.com/");
+    assertUserAgentForURLHasLinuxPlatformQuirk("http://docs.google.com/");
 
     assertUserAgentForURLHasMacPlatformQuirk("http://www.yahoo.com/");
@@ -114 +114 @@
     assertUserAgentForURLHasMacPlatformQuirk("http://web.whatsapp.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://www.chase.com/");
-    assertUserAgentForURLHasMacPlatformQuirk("http://drive.google.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://paypal.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");