Changeset 266899 in webkit

Timestamp:

Sep 10, 2020, 5:01:43 PM (6 years ago)

Author:

Wenson Hsieh

Message:

Address a post-commit review comment after r266887
​https://bugs.webkit.org/show_bug.cgi?id=216257

Reviewed by Darin Adler.

Remove a check that currently makes us conditionally set IsComputedStyleInvalidFlag if there is a computed
style in rare data. There should be no change in behavior; this just makes the code a bit simpler.

• dom/Element.cpp:

(WebCore::Element::invalidateStyle):
(WebCore::Element::storeDisplayContentsStyle):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Address a post-commit review comment after r266887
+        https://bugs.webkit.org/show_bug.cgi?id=216257
+
+        Reviewed by Darin Adler.
+
+        Remove a check that currently makes us conditionally set `IsComputedStyleInvalidFlag` if there is a computed
+        style in rare data. There should be no change in behavior; this just makes the code a bit simpler.
+
+        * dom/Element.cpp:
+        (WebCore::Element::invalidateStyle):
+        (WebCore::Element::storeDisplayContentsStyle):
+
 2020-09-10  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1973 +1973 @@
     // FIXME: This flag should be set whenever styles are invalidated while computed styles are present,
     // not just in this codepath.
-    if (hasRareData() && elementRareData()->computedStyle())
-        setNodeFlag(NodeFlag::IsComputedStyleInvalidFlag);
+    setNodeFlag(NodeFlag::IsComputedStyleInvalidFlag);
 }
 
@@ -2025 +2024 @@
     ASSERT(!renderer() || isPseudoElement());
     ensureElementRareData().setComputedStyle(WTFMove(style));
+    clearNodeFlag(NodeFlag::IsComputedStyleInvalidFlag);
 }