Changeset 267198 in webkit

Timestamp:

Sep 17, 2020, 10:47:28 AM (6 years ago)

Author:

jer.noble@apple.com

Message:

[iOS] YouTube does not route video to AirPlay the first time
​https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>

Reviewed by Eric Carlson.

Difficult to test this, since it requires an live AppleTV device.

During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.

• platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/ios/MediaSessionManagerIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-17  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] YouTube does not route video to AirPlay the first time
+        https://bugs.webkit.org/show_bug.cgi?id=216626
+        <rdar://problem/62222846>
+
+        Reviewed by Eric Carlson.
+
+        Difficult to test this, since it requires an live AppleTV device.
+
+        During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
+        be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
+        which explains the "only initial AirPlay fails" behavior.
+
+        * platform/audio/ios/MediaSessionManagerIOS.mm:
+        (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
+
 2020-09-17  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm

@@ -206 +206 @@
         return;
 
+    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
     nowPlayingSession->setShouldPlayToPlaybackTarget(supportsAirPlayVideo == SupportsAirPlayVideo::Yes);
-    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
 }