Changeset 267351 in webkit

Timestamp:

Sep 21, 2020, 12:00:46 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WPE] WKTR has lost access to Pulseaudio
​https://bugs.webkit.org/show_bug.cgi?id=216745

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-09-21
Reviewed by Carlos Garcia Campos.

Let Pulseaudio env vars pass through in the test environment, this is specially needed when
the test harness runs in the Flatpak sandbox.

• Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

• Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)
• Scripts/webkitpy/port/wpe.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-21  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK][WPE] WKTR has lost access to Pulseaudio
+        https://bugs.webkit.org/show_bug.cgi?id=216745
+
+        Reviewed by Carlos Garcia Campos.
+
+        Let Pulseaudio env vars pass through in the test environment, this is specially needed when
+        the test harness runs in the Flatpak sandbox.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.setup_environ_for_server):
+        * Scripts/webkitpy/port/wpe.py:
+        (WPEPort.setup_environ_for_server):
+
 2020-09-21  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -129 +129 @@
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
+        self._copy_value_from_environ_if_set(environment, 'PULSE_SERVER')
+        self._copy_value_from_environ_if_set(environment, 'PULSE_CLIENTCONFIG')
         for gst_variable in ('DEBUG', 'DEBUG_DUMP_DOT_DIR', 'DEBUG_FILE', 'DEBUG_NO_COLOR',
                              'PLUGIN_SCANNER', 'PLUGIN_PATH', 'PLUGIN_SYSTEM_PATH', 'REGISTRY',

trunk/Tools/Scripts/webkitpy/port/wpe.py

@@ -89 +89 @@
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
         self._copy_value_from_environ_if_set(environment, 'LIBGL_ALWAYS_SOFTWARE')
+        self._copy_value_from_environ_if_set(environment, 'PULSE_SERVER')
+        self._copy_value_from_environ_if_set(environment, 'PULSE_CLIENTCONFIG')
         self._copy_value_from_environ_if_set(environment, 'XR_RUNTIME_JSON')
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')