Changeset 267360 in webkit

Timestamp:

Sep 21, 2020, 1:08:53 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Timelines: remove "stop requested" marker
​https://bugs.webkit.org/show_bug.cgi?id=216423

Patch by Patrick Angle <Patrick Angle> on 2020-09-21
Reviewed by Devin Rousso.

Removed the "Stop Requested" timeline marker, which was made unneccesary in r267038 which makes the recording
head marker stop at the moment the stop was requested, even if more time is required to complete the processing
of incoming data.

• UserInterface/Models/TimelineMarker.js:
• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype._recordingReset):
(WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged):

• UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .markers > .marker.current-time::after):
(.timeline-ruler > .markers > .marker.stopping-time): Deleted.
(.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Deleted.
(@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Deleted.

• UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler.prototype.addMarker):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/TimelineMarker.js (modified) (1 diff)
• UserInterface/Views/TimelineOverview.js (modified) (3 diffs)
• UserInterface/Views/TimelineRuler.css (modified) (3 diffs)
• UserInterface/Views/TimelineRuler.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-09-21  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Timelines: remove "stop requested" marker
+        https://bugs.webkit.org/show_bug.cgi?id=216423
+
+        Reviewed by Devin Rousso.
+
+        Removed the "Stop Requested" timeline marker, which was made unneccesary in r267038 which makes the recording
+        head marker stop at the moment the stop was requested, even if more time is required to complete the processing
+        of incoming data.
+
+        * UserInterface/Models/TimelineMarker.js:
+        * UserInterface/Views/TimelineOverview.js:
+        (WI.TimelineOverview):
+        (WI.TimelineOverview.prototype._recordingReset):
+        (WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged):
+        * UserInterface/Views/TimelineRuler.css:
+        (.timeline-ruler > .markers > .marker.current-time::after):
+        (.timeline-ruler > .markers > .marker.stopping-time): Deleted.
+        (.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Deleted.
+        (@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Deleted.
+        * UserInterface/Views/TimelineRuler.js:
+        (WI.TimelineRuler.prototype.addMarker):
+
 2020-09-14  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/TimelineMarker.js

@@ -84 +84 @@
 
 WI.TimelineMarker.Type = {
-    StoppingTime: "stopping-time",
     CurrentTime: "current-time",
     LoadEvent: "load-event",

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

@@ -84 +84 @@
         this.addSubview(this._timelineRuler);
 
-        this._stoppingTimeMarker = null;
         this._currentTimeMarker = new WI.TimelineMarker(0, WI.TimelineMarker.Type.CurrentTime);
         this._timelineRuler.addMarker(this._currentTimeMarker);
@@ -817 +816 @@
 
         this._timelineRuler.addMarker(this._currentTimeMarker);
-
-        if (this._stoppingTimeMarker) {
-            this._stoppingTimeMarker.time = -1; // Hide the marker.
-            this._timelineRuler.addMarker(this._stoppingTimeMarker);
-        }
     }
 
@@ -1035 +1029 @@
     {
         switch (WI.timelineManager.capturingState) {
-        case WI.TimelineManager.CapturingState.Starting:
-            if (this._stoppingTimeMarker)
-                this._stoppingTimeMarker.time = -1; // Hide the marker when capturing resumes.
-            break;
-
         case WI.TimelineManager.CapturingState.Active:
             this._editInstrumentsButton.enabled = false;
             this._stopEditingInstruments();
-            break;
-
-        case WI.TimelineManager.CapturingState.Stopping:
-            if (!this._stoppingTimeMarker) {
-                this._stoppingTimeMarker = new WI.TimelineMarker(this._currentTime, WI.TimelineMarker.Type.StoppingTime);
-                this._timelineRuler.addMarker(this._stoppingTimeMarker);
-            } else
-                this._stoppingTimeMarker.time = this._currentTime;
             break;
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css

@@ -175 +175 @@
 }
 
-.timeline-ruler > .markers > .marker.stopping-time {
-    color: hsl(0, 0%, 75%);
-}
-
 .timeline-ruler > .markers > .marker.current-time {
     z-index: var(--timeline-current-time-z-index);
@@ -184 +180 @@
 }
 
-.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after {
+.timeline-ruler > .markers > .marker.current-time::after {
     top: var(--timeline-ruler-marker-after-offset);
     width: var(--timeline-ruler-marker-after-size);
@@ -295 +291 @@
 
 @media (prefers-color-scheme: dark) {
-    .timeline-ruler > .markers > .marker.stopping-time {
-        color: lightgrey;
-    }
-
     .timeline-ruler > .markers > .marker.dom-content-event {
         color: hsl(240, 100%, 70%);

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js

@@ -349 +349 @@
 
         switch (marker.type) {
-        case WI.TimelineMarker.Type.StoppingTime:
-            markerElement.title = WI.UIString("Recording stop requested \u2014 %s").format(Number.secondsToString(markerTime));
-            break;
         case WI.TimelineMarker.Type.LoadEvent:
             markerElement.title = WI.UIString("Load \u2014 %s").format(Number.secondsToString(markerTime));