Changeset 267372 in webkit

Timestamp:

Sep 21, 2020, 3:03:44 PM (6 years ago)

Author:

Peng Liu

Message:

Tapping to zoom in and out causes video to become very small on some iPhone models
​https://bugs.webkit.org/show_bug.cgi?id=216635

Reviewed by Jer Noble.

• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer resolveBounds]): On some iPhone models, AVKit does not
change "bounds" of WebAVPlayerLayer after changing its video gravity. Therefore,
in this function, "modelVideoLayerFrame" and "bounds" might be the same. But we
still need to update the video layer frame in the Web process.

(-[WebAVPlayerLayer setVideoGravity:]): On some iPhone models, AVKit does
not call -[WebAVPlayerLayer:layoutSublayers] immediately after changing
the video gravity. Forcing a layout can fix that.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/VideoFullscreenInterfaceAVKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-21  Peng Liu  <peng.liu6@apple.com>
+
+        Tapping to zoom in and out causes video to become very small on some iPhone models
+        https://bugs.webkit.org/show_bug.cgi?id=216635
+
+        Reviewed by Jer Noble.
+
+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+        (-[WebAVPlayerLayer resolveBounds]): On some iPhone models, AVKit does not
+        change "bounds" of WebAVPlayerLayer after changing its video gravity. Therefore,
+        in this function, "modelVideoLayerFrame" and "bounds" might be the same. But we
+        still need to update the video layer frame in the Web process.
+
+        (-[WebAVPlayerLayer setVideoGravity:]): On some iPhone models, AVKit does
+        not call -[WebAVPlayerLayer:layoutSublayers] immediately after changing
+        the video gravity. Forcing a layout can fix that.
+
 2020-09-21  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

@@ -333 +333 @@
     [CATransaction setAnimationDuration:0];
     [CATransaction setDisableActions:YES];
-    
-    if (!CGRectEqualToRect(self.modelVideoLayerFrame, [self bounds])) {
-        self.modelVideoLayerFrame = [self bounds];
-        if (auto* model = _fullscreenInterface->videoFullscreenModel())
-            model->setVideoLayerFrame(_videoSublayerFrame);
-
-        _previousVideoGravity = _videoGravity;
-    }
+
+    self.modelVideoLayerFrame = [self bounds];
+    if (auto* model = _fullscreenInterface->videoFullscreenModel())
+        model->setVideoLayerFrame(_videoSublayerFrame);
+
+    _previousVideoGravity = _videoGravity;
+
     [(UIView *)[_videoSublayer delegate] setTransform:CGAffineTransformIdentity];
     
@@ -375 +374 @@
     if (auto* model = _fullscreenInterface->videoFullscreenModel())
         model->setVideoLayerGravity(gravity);
+
+    [self setNeedsLayout];
 }